convert ckeditor5-link to work for resource links #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alicewriteswrongs
force-pushed
the
ap/resource-link-fork
branch
2 times, most recently
from
3066afd
to
e24f3f8
Compare
alicewriteswrongs
changed the title
6 tasks
This uses the ckeditor Link plugin as the basis for a new resource link plugin which allows resource links to be inline, meaning that the UUID for the resource is stored as an attribute of a span of text instead of as a block element. This is being introduced to ocw-studio in this PR: mitodl/ocw-studio#589 pr #1
alicewriteswrongs
force-pushed
the
ap/resource-link-fork
branch
from
77b30a1
to
a1a6bda
Compare
alicewriteswrongs
added a commit
that referenced
this pull request
Nov 29, 2021
This uses the ckeditor Link plugin as the basis for a new resource link plugin which allows resource links to be inline, meaning that the UUID for the resource is stored as an attribute of a span of text instead of as a block element. This is being introduced to ocw-studio in this PR: mitodl/ocw-studio#589 pr #1
ChristopherChudzicki
pushed a commit
that referenced
this pull request
Dec 13, 2022
This uses the ckeditor Link plugin as the basis for a new resource link plugin which allows resource links to be inline, meaning that the UUID for the resource is stored as an attribute of a span of text instead of as a block element. This is being introduced to ocw-studio in this PR: mitodl/ocw-studio#589 pr #1
ChristopherChudzicki
pushed a commit
that referenced
this pull request
Dec 14, 2022
This uses the ckeditor Link plugin as the basis for a new resource link plugin which allows resource links to be inline, meaning that the UUID for the resource is stored as an attribute of a span of text instead of as a block element. This is being introduced to ocw-studio in this PR: mitodl/ocw-studio#589 pr #1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this has the changes I've been making to the CKEditor
Linkplugin code in order for us to use it as the base for a better user experience for linking to resources in our markdown editor in ocw-studio.The changes are basically, right now, limited to renaming constants used to identify the model type, command names, and so on so that they do not collide with the existing, normal link plugin. The hope is that if we keep this changeset small, once we've merged this PR into our forked repo we'll be able to keep this repo up-to-date with upstream in order to ensure that this resource link plugin will continue to work with the rest of the ckeditor ecosystem.