-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove EdX-Api-Key usage #2217
Conversation
c93f5ac
to
8f7a319
Compare
9b73ef9
to
45f6e92
Compare
@asadali145 can you please review as discussed to bump edx-api-client version to 1.9.0? The edx-api-client version 1.9.0 was published at mitodl/edx-api-client#105. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There is an issue with the enrollments which is not part of this PR. I will try to finalize the steps and create another issue.
CC: @arslanashraf7
@asadali145 / @mudassir-hafeez Thanks. It would be good to keep MITx Online dev team in loop about this change. |
What are the relevant tickets?
#2102
Description (What does it do?)
This PR removes EDX_API_KEY usage as Open edX is going to remove the EDX_API_KEY. Details can be found at openedx/edx-platform#34039. It also fixes a potential impact on the deactivate_enrollment API for non-staff users if the EdX-Api-Key is removed.
Screenshots (if appropriate):
How can this be tested?
EdX-Api-Key
for client requests. For example.You can also use management commands to test where applicable. i.e:
regenerate_edx_auth_tokens
repair_missing_courseware_records
retry_edx_enrollment
sync_enrollments
update_edx_profiles
Important to be tested:
audit
, andverified
.unenroll_enrollment
refund_fulfilled_order
transfer_enrollment
or can test the course unenroll from user dashboard.
Additional Context