Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update management command for user deferrals to include courses with closed enrollments #2646

Conversation

aliraza-abbasi
Copy link
Contributor

Pre-Flight checklist

  • Screenshots and design review for any changes that affect layout or styling
    • Desktop screenshots
    • Mobile width screenshots
  • Migrations
    • Migration is backward-compatible with the current production code
  • Testing
    • Code is tested
    • Changes have been manually tested
  • Settings
    • New settings are documented and present in app.json
    • New settings have reasonable development defaults, if applicable

What are the relevant tickets?

#2631

What's this PR do?

A site admin can run the defer_enrollment management command to transfer a user to a course run even after the enrollment period ends

How should this be manually tested?

  • edX and xpro should be working on the local machine
  • Try to enroll a user in an enrollment-expired course run using the defer_enrollment command using -f argument
  • Validate the user is enrolled in the given course run on xpro and edX on your localhost

Copy link
Contributor

@arslanashraf7 arslanashraf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just code reviewed, Testing it now.

courses/api_test.py Outdated Show resolved Hide resolved
courseware/api_test.py Show resolved Hide resolved
courseware/api.py Show resolved Hide resolved
@aliraza-abbasi aliraza-abbasi force-pushed the aliraza/issue-2631-Update-management-command-for-user-deferrals-to-include-courses-with-closed-enrollments branch from f6d9c09 to e2ab040 Compare May 18, 2023 22:38
Copy link
Contributor

@arslanashraf7 arslanashraf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just one last piece of comment, Feel free to merge after that.

courses/api_test.py Outdated Show resolved Hide resolved
Copy link
Contributor

@arslanashraf7 arslanashraf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aliraza-abbasi One more comment before you merge this, Did you upgrade the requirements with pip-compile?
I just noticed that pip-compile generates a different output than this PR, Please fix that before you merge the PR.

@aliraza-abbasi aliraza-abbasi force-pushed the aliraza/issue-2631-Update-management-command-for-user-deferrals-to-include-courses-with-closed-enrollments branch from 6135e0a to 4a17df8 Compare May 22, 2023 22:02
@aliraza-abbasi aliraza-abbasi merged commit f67a38c into master May 22, 2023
@aliraza-abbasi aliraza-abbasi deleted the aliraza/issue-2631-Update-management-command-for-user-deferrals-to-include-courses-with-closed-enrollments branch May 22, 2023 22:35
This was referenced May 25, 2023
@odlbot odlbot mentioned this pull request Jun 2, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants