Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: hide the Webinars link from top app bar #2658

Merged
merged 1 commit into from
May 25, 2023

Conversation

arslanashraf7
Copy link
Contributor

@arslanashraf7 arslanashraf7 commented May 25, 2023

Pre-Flight checklist

  • Screenshots and design review for any changes that affect layout or styling
    • Desktop screenshots
    • Mobile width screenshots
  • Migrations
    • Migration is backwards-compatible with current production code
  • Testing
    • Code is tested
    • Changes have been manually tested
  • Settings
    • New settings are documented and present in app.json
    • New settings have reasonable development defaults, if applicable

What are the relevant tickets?

None, Hot fix

What's this PR do?

  • Hides the Webinars link from the Top App bar

How should this be manually tested?

  • Just check that there is no Webinars link in the app bar and the design stays intact

Where should the reviewer start?

(Optional)

Any background context you want to provide?

(Optional)

Screenshots (if appropriate)

This PR is based on master which has some other functionalities e.g. Courses drop-down but it won't be there in production.
image

What GIF best describes this PR or how it makes you feel?

(Optional)

Copy link
Contributor

@annagav annagav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arslanashraf7 arslanashraf7 merged commit 6feabc7 into master May 25, 2023
@arslanashraf7 arslanashraf7 deleted the arslan/hide-webinars-link branch May 25, 2023 18:34
@odlbot odlbot mentioned this pull request May 25, 2023
2 tasks
This was referenced May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants