-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove EdX-Api-Key usage #2982
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
f4708aa
to
428d062
Compare
6e17d02
to
d2affc3
Compare
ce2ecc8
to
243d45d
Compare
0391589
to
d3b8678
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We need to merge mitodl/edx-api-client#104 and release the edx-api-client and then update this xPro PR with the new version of edx-api-client.
@mudassir-hafeez there is conflict. Could you resolve? |
d6cec62
to
308c948
Compare
e451e6c
to
703a43e
Compare
703a43e
to
91b7b89
Compare
44ed4f9
to
2ff6c4d
Compare
for more information, see https://pre-commit.ci
@asadali145 can you please re-review as the conflict is resolved? also bumped edx-api-client version to 1.9.0 as it was published to PYPI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What are the relevant tickets?
#2872
Description (What does it do?)
This PR removes EDX_API_KEY usage as Open edX is going to remove the EDX_API_KEY. Details can be found at openedx/edx-platform#34039.
Screenshots (if appropriate):
How can this be tested?
EdX-Api-Key
for client requests, or follow the testing instructions mentioned in refactor: remove X-EdX-Api-Key usage edx-api-client#104. It's important to thoroughly test all the instructions provided in this PR.Additional Context