Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(external course sync): sync course run dates if they are missing #3027

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

asadali145
Copy link
Contributor

What are the relevant tickets?

Follow up fix for #2998

Description (What does it do?)

Course run dates were not updating If an external course run ID is added for a run and dates are null but the API has dates.

How can this be tested?

  • Checkout master branch
  • Run command ./manage.py sync_external_course_runs --vendor-name emeritus
  • Go to Django Admin, filter Emeritus course runs.
  • Remove start and end date for a course run. The external course run ID should exist.
  • Now run the management command again ./manage.py sync_external_course_runs --vendor-name emeritus
  • The start and end date won't update.
  • Checkout this branch and run the command again.
  • Dates should sync.

Copy link
Contributor

@arslanashraf7 arslanashraf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 We should have a test for this but as discussed we can add them in a followup while working on #3028.

@asadali145 asadali145 merged commit eaf7ad3 into master Jun 26, 2024
7 checks passed
@asadali145 asadali145 mentioned this pull request Jun 26, 2024
1 task
@odlbot odlbot mentioned this pull request Jun 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants