-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tasawer/242/site notifications #309
Conversation
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
==========================================
+ Coverage 94.03% 94.05% +0.01%
==========================================
Files 170 171 +1
Lines 5771 5787 +16
Branches 342 343 +1
==========================================
+ Hits 5427 5443 +16
Misses 280 280
Partials 64 64
Continue to review full report at Codecov.
|
4441761
to
d2a69f7
Compare
b8d012f
to
d4e0999
Compare
7da90a5
to
ecbee11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looking good, just a few small things.
9004715
to
d999e8f
Compare
@rhysyngsun Suggestions applied. |
Pre-Flight checklist
What are the relevant tickets?
Fixes #242
What's this PR do?
Add feature for site notifications.
How should this be manually tested?
cms/snippets/cms/sitenotification/
Any background context you want to provide?
RFC: #306
Screenshots (if appropriate)
Wagtail:
Rendered:
Out of scope: