Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme tweaks based on feedback #45

Closed
4 tasks done
rhysyngsun opened this issue Mar 28, 2024 · 2 comments · Fixed by #46
Closed
4 tasks done

Theme tweaks based on feedback #45

rhysyngsun opened this issue Mar 28, 2024 · 2 comments · Fixed by #46
Assignees
Labels
product:mit-open Issues related to the MIT Open product

Comments

@rhysyngsun
Copy link
Contributor

rhysyngsun commented Mar 28, 2024

Acceptance Criteria

  • The account page isn't styled (user ends up here if they have missing profile information and "login" via a password reset)
  • The login page where a user enters missing user/profile information hasn't been styled (different than the account page)
  • Use "Log in" and "Sign up" wording in all places
  • Rename usages like "Forgot Password" to "Reset Password"
@rhysyngsun rhysyngsun self-assigned this Mar 28, 2024
@pdpinch pdpinch added the product:mit-open Issues related to the MIT Open product label Apr 2, 2024
@pdpinch
Copy link
Member

pdpinch commented Apr 2, 2024

@rhysyngsun you checked this box, but I don't think it's working.

The page where a user enters missing user/profile information hasn't been styled.

I tried to log in via discussions-rc.odl.mit.edu using an existing account. Because these accounts don't share first name and last name, I was forced into the Personal Info page on keycloak which has the default Keycloak styling:

image

@pdpinch pdpinch reopened this Apr 2, 2024
@pdpinch
Copy link
Member

pdpinch commented Apr 2, 2024

My comment is out of scope for this issue. We'll open another issue to address it.

@pdpinch pdpinch closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:mit-open Issues related to the MIT Open product
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants