Add realm level setting(s) for Open-specific values #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhysyngsun
changed the title
collinpreston
suggested changes
Apr 12, 2024
ol-keycloak/ol-spi/src/main/java/edu/mit/keycloak/util/OpenAttribute.java
Outdated
Show resolved
Hide resolved
ol-keycloak/ol-spi/src/main/java/edu/mit/keycloak/forms/login/freemarker/models/OpenBean.java
Outdated
Show resolved
Hide resolved
...ak/ol-spi/src/main/java/edu/mit/keycloak/forms/login/freemarker/models/LoginAttemptBean.java
Outdated
Show resolved
Hide resolved
...pi/src/main/java/edu/mit/keycloak/forms/login/freemarker/OlFreeMarkerLoginFormsProvider.java
Outdated
Show resolved
Hide resolved
ol-keycloak/ol-spi/src/main/java/edu/mit/keycloak/admin/ui/OpenAdminUiTab.java
Outdated
Show resolved
Hide resolved
ol-keycloak/ol-spi/src/main/java/edu/mit/keycloak/admin/ui/OpenAdminUiTab.java
Outdated
Show resolved
Hide resolved
ol-keycloak/ol-spi/src/main/java/edu/mit/keycloak/util/OpenAttribute.java
Outdated
Show resolved
Hide resolved
collinpreston
suggested changes
Apr 12, 2024
ol-keycloak/ol-spi/src/main/java/edu/mit/keycloak/forms/login/freemarker/models/OpenBean.java
Outdated
Show resolved
Hide resolved
ol-keycloak/ol-spi/src/main/java/edu/mit/keycloak/admin/ui/OpenAdminUiTab.java
Outdated
Show resolved
Hide resolved
| @@ -81,7 +81,7 @@ | |||
| <header class="pf-v5-c-login__main-header"> | |||
| <div class="pf-v5-u-mb-2xl"> | |||
| <h1 class="pf-v5-c-title pf-m-4xl"> | |||
| <a href="https://mit.edu" class="logo-link pf-v5-u-display-flex pf-v5-u-justify-content-center"> | |||
| <a href="${open.homeUrl}" class="logo-link pf-v5-u-display-flex pf-v5-u-justify-content-center"> | |||
There was a problem hiding this comment.
Does this actually work? I'm getting an error:
- Failed at: ${open.homeUrl} [in template "template.ftl" in macro "registrationLayout" at line 84, column 22]
- Reached through: @layout.registrationLayout displayMes... [in template "error.ftl" at line 2, column 1]
There was a problem hiding this comment.
This worked for me, that error would make me think the latest code wasn't loaded in, but you wouldn't be seeing any of the rest of it either if that was the case. That particular property isn't conditional like loginAttempt is...
collinpreston
removed
the
Needs Review
...pi/src/main/java/edu/mit/keycloak/forms/login/freemarker/OlFreeMarkerLoginFormsProvider.java
Outdated
Show resolved
Hide resolved
|
@collinpreston should be all set, although I'm not sure why you'd be hitting this error: #52 (comment) |
|
Note you'll need to re-enter the setting, since the key changed. |
collinpreston
approved these changes
Apr 12, 2024
collinpreston
removed
the
Needs Review
rhysyngsun
force-pushed
the
nl/open-link
branch
from
4becbe2
to
f8eff22
Compare
rhysyngsun
added a commit
that referenced
this pull request
Apr 16, 2024
Revert "Merge pull request #52 from mitodl/nl/open-link"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Part of #47
Description (What does it do?)
This adds a
UITabProviderwhich adds an "MIT Open" tab to the realm admin interface as well as exposing the configured data via realm attributes (only 1 for now).I also did some refactoring of the template provider to organize the properties under beans so they're not all at the top level.
Note: there are several other places that need to use this url too, I'm going to deal with that in a separate PR later. I only did enough here to prove that it works.
Screenshots (if appropriate):
How can this be tested?
http://open.odl.local:8083/).