-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Tutor in CI #339
Added Tutor in CI #339
Conversation
807f669
to
629e410
Compare
This PR is waiting for the redwood release. For now, it is only working for the quince release. It's failing on master because the master branch of edx-platform is broken due to a dependency version issue. For redwood, the tutor is not yet ready (release notes for the latest major release v17.0.0). |
fd19cf7
to
e0edb5e
Compare
cd /open-edx-plugins | ||
|
||
# Installing dev dependencies | ||
pip install poetry | ||
poetry install --no-interaction --only dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this code of installing dev dependencies as this resulted in a conflict with tutor edx-platform dependencies. I believe all the required dev dependencies are already installed in the tutor edx-platform container.
pyproject.toml
Outdated
[tool.poetry.group.dev.dependencies] | ||
black = "*" | ||
isort = "*" | ||
pre-commit = "^3.0.0" | ||
pytest = "^8.0.0" | ||
twine = "^5.0.0" | ||
ruff = "^0.4.0" | ||
pytest-mock = "^3.14.0" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this block get deleted? We can legitimately get rid of black and isort, but the rest should be retained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we were only using these dependencies in the CI, therefore deleted them, will re-add them in the next commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the deletion of the dev dependencies, the rest of the changes here look good.
f2cd12c
to
159e000
Compare
What are the relevant tickets?
https://github.com/mitodl/hq/issues/4443
Description (What does it do?)
This PR replaces devstack with tutor in the CI for initializing edx-platform and running the integration tests of plugins. More details in the ticket
How can this be tested?
pants build ::
pip install tutor==17.0.6
pip install tutor==18.0.0
tutor mounts add .
tutor images build openedx-dev
tutor dev launch --non-interactive
tutor dev stop