Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ mock 1.3.0 #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⬆️ mock 1.3.0 #69

wants to merge 1 commit into from

Conversation

nikolas
Copy link
Contributor

@nikolas nikolas commented Oct 18, 2017

No description provided.

@giocalitri
Copy link

Thanks for your contribution.
Can you please provide some context in the description?

@coveralls
Copy link

coveralls commented Oct 24, 2017

Coverage Status

Coverage remained the same at 98.442% when pulling 74eed4b on nikolas:patch-3 into c407bbb on mitodl:master.

@giocalitri
Copy link

I honestly think this requires more work:

We should al least upgrade the test_requirements.txt file as well, qui in general it would be great if setup.py loads the requirements from requirements.txt and test_requirements.txt instead of having duplicate lists.

@nikolas
Copy link
Contributor Author

nikolas commented Oct 25, 2017

Yeah, I agree. I just updated this because it happens to work and, in my day-to-day work, if a newer version of a test library produces passing tests, it might as well be merged. But I understand if you'd rather do a more complete overhaul of the test dependencies instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants