Output url_name instead of url_name_orig #36
Conversation
Was getting:
`TypeError: can't use a string pattern on a bytes-like object`
with non-trivial courses; in cases where the `if` statement above this
outdented section was not triggered.
|
@noisecapella Please review #37; I had an error when manually testing this branch. This fix isn't due to a bug introduced in your branch, but I think it's a good time to add it. |
Fixed error.
|
Ok, it's merged |
Output url_name instead of url_name_orig
|
Uh, did we ever hear anything from Ike on this? |
|
Sorry, should this not have been merged? Should I revert it? |
|
One of the most useful ways to employ xbundle is to make it rename Studio's This change breaks this use case. I would prefer for it to be reverted. -Ike. On Thu, Jul 16, 2015 at 12:00 PM, Shawn Milochik notifications@github.com
|
|
Reverted. |
For LORE it's useful to keep the url_name attribute as
url_nameso that users can match old learning resources with the modified copy in LORE. My understanding is that url_name_orig is not used anywhere but I'd be happy to add a new option if this PR would break backwards compatibility.cc @ichuang