Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --ask-become-pass #1007

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Fix --ask-become-pass #1007

merged 2 commits into from
Apr 12, 2024

Conversation

moreati
Copy link
Member

@moreati moreati commented Jul 7, 2023

Previously f150387 fixed the priority of ansible_become_pass over ansible_become_password, but broke --ask-become-pass.
Fixes #952.

@moreati
Copy link
Member Author

moreati commented Jul 7, 2023

WIP, one of the tests has regressed

TASK [reset the connection _raw_params=reset_connection] ***************************************************************
Friday 07 July 2023  21:01:05 +0100 (0:00:00.196)       0:05:39.075 *********** 
ERROR! Unexpected Exception, this is probably a bug: AttributeError: 'NoneType' object has no attribute 'get_option'
to see the full traceback, use -vvv
Exception occurred while running: ['./run_ansible_playbook.py', 'all.yml', '-i', '/tmp/mitogen_ci_lib9ygmmca5/hosts']
Traceback (most recent call last):
  File "/home/alex/src/mitogen/.ci/ansible_tests.py", line 89, in <module>
    ci_lib.run('./run_ansible_playbook.py %s -i "%s" %s',
  File "/home/alex/src/mitogen/.ci/ci_lib.py", line 86, in run
    ret = subprocess.check_call(argv, **kwargs)
  File "/usr/lib/python3.10/subprocess.py", line 369, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['./run_ansible_playbook.py', 'all.yml', '-i', '/tmp/mitogen_ci_lib9ygmmca5/hosts']' returned non-zero exit status 250.

@stefanor
Copy link
Contributor

@moreati: Thanks for the more frequent releases. This is one of the patches that Debian has been carrying for a while, and I'd appreciate it if you would re-review it for completion.

Previously f150387 fixed the priority of
ansible_become_pass over ansible_become_password, but broke --ask-become-pass.
Fixes mitogen-hq#952.
Should have higher uptime, and make us less of a burden. Refs mitogen-hq#1058
@moreati moreati marked this pull request as ready for review April 12, 2024 13:49
@moreati moreati merged commit bb9c51b into mitogen-hq:master Apr 12, 2024
46 checks passed
@moreati moreati deleted the ask-become-pass branch April 12, 2024 13:50
@krushik krushik mentioned this pull request May 8, 2024
@emillumine
Copy link

Hi @moreati!
Any chance there will be a new mitogen release soon that includes this fix? I'm stuck to mitogen 0.3.3 (and so ansible 5 and python 3.11) because of #726 that seems to be resolved with this fix according to other people. I see the last release was mitogen 0.3.7 on Apr 9, before this fix was merged into master.
Thanks for any update on the next release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ansible become / sudo broken since commit f1503874de82353cbed8b51408d20fdfa899f8f7
3 participants