Release 0.3.6 #1051
Merged
Release 0.3.6 #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare 0.3.5 release, start 0.3.6 development
docs: Correct PEP 451 hyperlink
Co-authored-by: Orion Poplawski <orion@nwra.com>
If casting a string fails then raise a TypeError. This is potentially an API breaking change; chosen as the lesser evil vs. allowing silent errors. `cast()` relies on `bytes(obj)` & `str(obj)` returning the respective supertype. That's no longer the case for `AnsibleUnsafeBytes` & `AnsibleUnsafeText`; since fixes/mitigations for CVE-2023-5764. fixes mitogen-hq#1046, refs mitogen-hq#977 See also - GHSA-7j69-qfc3-2fq9 - ansible/ansible#82293
Prep work for ansible_mitogen.utils.unsafe
Follwing fixes in Ansible 7-9 for CVE-2023-5764 cating `AnsibleUnsafeBytes` & `AnsibleUnsafeText` to `bytes()` or `str()` requires special handling. The handling is Ansible specific, so it shouldn't go in the mitogen package but rather the ansible_mitogen package. `ansible_mitogen.utils.unsafe.cast()` is most like `mitogen.utils.cast()`. During development it began as `ansible_mitogen.utils.unsafe.unwrap_var()`, closer to an inverse of `ansible.utils.unsafe_procy.wrap_var()`. Future enhancements may move in this direction. refs mitogen-hq#977, refs mitogen-hq#1046 See also - GHSA-7j69-qfc3-2fq9 - ansible/ansible#82293 - https://github.com/mitogen-hq/mitogen/wiki/AnsibleUnsafe-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeErrorinmitogen.util.cast()when casting a string subtype tobytes()orstr()fails. This ispotentially an API breaking change. Failures previously passed silently.
ansible_mitogen.util.cast(), to castansible.utils.unsafe_proxy.AnsibleUnsafeobjects in Ansible 7+.cc @dw