Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional fixes #59

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Additional fixes #59

merged 3 commits into from
Jul 20, 2023

Conversation

dehall
Copy link
Collaborator

@dehall dehall commented May 4, 2023

  1. Don't consider missing addresses at all in household inference. Originally the logic would strip these out at the end but one data owner revealed this could cause performance issues, so now strip them out before indexing. This means these rows will not be considered at all, and will be their own "household". At some point we should probably also consider the option of not assigning individuals a household at all.
  2. Remove textdistance "extras" from requirements.txt since some users had trouble with this on windows. A note will be added to the installation instructions on the wiki that installing extras is optional
  3. Fix an issue with counting addresses in data_analysis.py. The issue is related to how the code combines address_street and address_detail, since it gets called from both data_analysis.py and extract.py.
  4. Count blank strings as "missing" in data_analysis
  5. Wrap some values in max(int(x), 1) in case x is a fraction 0 < x < 1

@dehall
Copy link
Collaborator Author

dehall commented Jul 20, 2023

I thought I merged this months ago

@dehall dehall merged commit 38bd3e9 into master Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant