Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo cleanup #132

Merged
merged 3 commits into from
Sep 8, 2020
Merged

Monorepo cleanup #132

merged 3 commits into from
Sep 8, 2020

Conversation

rbclark
Copy link
Contributor

@rbclark rbclark commented Sep 3, 2020

Add code-workspace for vscode

This works around lack of multi-root support in vetur: vuejs/vetur#424 (comment)

Create interfaces for all DTO's in heimdall-server

By creating interfaces, these interfaces can be used in the Heimdall frontend and allow assurance that the data being passed back and forth is consistent

Deduplicate tsconfig files

Add additional testing steps to ensure that the backend and frontend package lists still work independently.

Upgrade version of PrismJS and update PrismJS Ruby regex override to new location (this is used to add inspec format support to Prism)

Bialogs
Bialogs previously approved these changes Sep 3, 2020
Copy link
Contributor

@Bialogs Bialogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs the lint run.

Otherwise we've gone over this a few times and I'm in agreement.

@rbclark rbclark force-pushed the monorepoCleanup branch 2 times, most recently from cf3800e to b84e2cc Compare September 4, 2020 15:26
@rbclark rbclark changed the title Monorepo cleanup WIP: Monorepo cleanup Sep 4, 2020
@rbclark rbclark force-pushed the monorepoCleanup branch 2 times, most recently from de94801 to 9905c17 Compare September 8, 2020 13:39
Robert Clark added 2 commits September 8, 2020 09:43
This works around lack of multi-root support in vetur: vuejs/vetur#424 (comment)
By creating interfaces, these interfaces can be used in the Heimdall frontend and allow assurance that the data being passed back and forth is consistent

Deduplicate tsconfig files

Add additional testing steps to ensure that the backend and frontend package lists still work independently.
@rbclark rbclark changed the title WIP: Monorepo cleanup Monorepo cleanup Sep 8, 2020
@rbclark rbclark merged commit 379b589 into master Sep 8, 2020
@rbclark rbclark deleted the monorepoCleanup branch September 8, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants