Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for XLSXTool and add system tests in CI #130

Merged
merged 6 commits into from
Apr 6, 2020
Merged

Add unit tests for XLSXTool and add system tests in CI #130

merged 6 commits into from
Apr 6, 2020

Conversation

Bialogs
Copy link
Contributor

@Bialogs Bialogs commented Apr 3, 2020 •
edited
Loading

This PR also

  • Fixes a bug in XLSXTool when looking up the NIST control number from the CIS control number. Providing the wrong data type to the function.
  • Tracks PDF in git-lfs
  • Cleans up some require lines in cli.rb
  • Renames the file XLSXTool is inside for better require and autoload maintainability

@Bialogs Bialogs changed the title Xlsx tests Add unit tests for XLSXTool and add system tests in CI Apr 3, 2020
@Bialogs Bialogs merged commit e50e93d into master Apr 6, 2020
@Bialogs Bialogs deleted the xlsx-tests branch April 6, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Bialogs