Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VULCAN-581: Enhance Import from Spreadsheet workflow #582

Merged
merged 1 commit into from
May 18, 2023

Conversation

vanessuniq
Copy link
Contributor

Fix the import from spreadsheet workflow to properly create rule satisfaction when file contains rules satisfied by many others

Fix #581

…sfaction when file contains rules satistied by many others

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
@vanessuniq vanessuniq added the bug Something isn't working label May 18, 2023
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-582 May 18, 2023 00:57 Inactive
@rlakey
Copy link
Contributor

rlakey commented May 18, 2023

So as long as "Satisfied By: " is in the "Vendor Comments" column with a comma separated list it will parse that if I am reading it correctly?

@vanessuniq
Copy link
Contributor Author

So as long as "Satisfied By: " is in the "Vendor Comments" column with a comma separated list it will parse that if I am reading it correctly?

it currently handles comma or space separated, or the edge case where multiple "Satisfied By: " statement and duplicated STIG ID. The following will parse correctly:

  • Satisfied By: AMZL-02-710030, AMZL-02-710040
  • Satisfied By: AMZL-02-710030 AMZL-02-710040
  • Satisfied By: AMZL-02-710030 . Satisfied By: AMZL-02-710030, AMZL-02-710040 .
  • Satisfied By: AMZL-02-710030 . Satisfied By: AMZL-02-710040

@vanessuniq vanessuniq merged commit 8be341d into master May 18, 2023
@vanessuniq vanessuniq deleted the 581-import-from-a-spreadsheet-bug branch May 18, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Merged
2 participants