Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling SMTP feature to send emails via ActionMailer #584

Conversation

smarlaku820
Copy link
Contributor

  • Invoking the UserMailer mailer via the Application Controller
  • So, far the SMTP email templates have been added around reviews
  • SMTP notifications will be triggered to the project_admins CCing the user requesting a review.
  • user will be notified if the review request is approved or revoked
  • If the Admins request for more changes, the user will also be notified of the same.

Attaching the sample screenshots

Welcome Email

welcome_user_smtp

Request Review

request_review_smtp

Request Additional Changes

request_review_changes_smtp

Approve Request

approve_review_smtp

Revoke Request

revoke_review_smtp

@smarlaku820 smarlaku820 added V3.0 enhancement Pull requests that add a new feature javascript Pull requests that update Javascript code ruby Pull requests that update Ruby code vmw technical labels May 25, 2023
@smarlaku820 smarlaku820 self-assigned this May 25, 2023
@smarlaku820 smarlaku820 linked an issue May 25, 2023 that may be closed by this pull request
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-584 May 25, 2023 18:25 Inactive
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-584 May 25, 2023 18:46 Inactive
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-584 May 25, 2023 19:18 Inactive
…eated Instance Variables to Avoid DB Model access from views
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-584 May 26, 2023 17:02 Inactive
app/mailers/user_mailer.rb Show resolved Hide resolved
app/mailers/user_mailer.rb Outdated Show resolved Hide resolved
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-584 May 26, 2023 17:10 Inactive
@aaronlippold
Copy link
Member

https://github.com/excid3/noticed?? useful?

@vanessuniq vanessuniq temporarily deployed to vulcan-pr-584 May 26, 2023 18:12 Inactive
@smarlaku820
Copy link
Contributor Author

@aaronlippold ,

Thank you for suggesting the library. Although I haven't reviewed it yet, I'm open to considering it since it appears to offer extensive support for various delivery methods, which could be beneficial for our project

@vanessuniq
Copy link
Contributor

https://github.com/excid3/noticed?? useful?

This could solve several delivery methods in one implementation. @smarlaku820 what do you think? I'll try to play with it.

@vanessuniq
Copy link
Contributor

@aaronlippold ,

Thank you for suggesting the library. Although I haven't reviewed it yet, I'm open to considering it since it appears to offer extensive support for various delivery methods, which could be beneficial for our project

@smarlaku820 Should we wait on this PR, try to use the gem Aaron suggested to see how it works out??

@aaronlippold
Copy link
Member

I always like it when others work through the hard stuff and push it into a lib for me :)

@smarlaku820
Copy link
Contributor Author

@vanessuniq

I haven't got the bandwidth for the next couple of weeks. Maybe, I will take a look at the lib after that.

@vanessuniq vanessuniq merged commit ac486ee into master May 29, 2023
@vanessuniq vanessuniq deleted the 551-implementing-actionmailer-for-sending-email-notifications branch May 29, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests that add a new feature javascript Pull requests that update Javascript code ruby Pull requests that update Ruby code technical V3.0 vmw
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementing ActionMailer for sending email notifications
3 participants