Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If null data just return for related info #602

Merged
merged 2 commits into from
Aug 22, 2023
Merged

If null data just return for related info #602

merged 2 commits into from
Aug 22, 2023

Conversation

freddyfeelgood
Copy link
Contributor

Modal form would not load the list if certain data was null, and modal form would not function correctly.

@vanessuniq vanessuniq temporarily deployed to vulcan-pr-602 August 22, 2023 19:52 Inactive
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-602 August 22, 2023 19:56 Inactive
@vanessuniq vanessuniq added the bug Something isn't working label Aug 22, 2023
vanessuniq
vanessuniq approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@vanessuniq vanessuniq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

@vanessuniq vanessuniq merged commit 0cd2aa5 into master Aug 22, 2023
2 checks passed
@vanessuniq vanessuniq deleted the Fix-related-modal-not-loading-if-data-missing branch August 22, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanessuniq vanessuniq vanessuniq approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Vulcan - Project Plan
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freddyfeelgood @vanessuniq