Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable user to select which component to excel export #610

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

vanessuniq
Copy link
Contributor

Vulcan is facing memory issues when attempting to excel export large projects.
The implemented solution break data export into smaller batches to reduce memory consumption. This is done by allowing users to select which components they would like to export.

Screenshot 2023-09-25 at 6 43 08 PM

Fix #600

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
@vanessuniq vanessuniq added bug Something isn't working enhancement Pull requests that add a new feature vmw labels Sep 25, 2023
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-610 September 25, 2023 22:54 Inactive
@smarlaku820
Copy link
Contributor

smarlaku820 commented Sep 26, 2023

Hey @vanessuniq ,

Looks good.

I have an observation - If one chose, select all then the context that Export Selected Components remains somewhat unclear. so, should we just say simply, Export (button) for the purposes of clarity ?

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
…ease

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-610 September 26, 2023 19:31 Inactive
@vanessuniq
Copy link
Contributor Author

Hey @vanessuniq ,

Looks good.

I have an observation - If one chose, select all then the context that Export Selected Components remains somewhat unclear. so, should we just say simply, Export (button) for the purposes of clarity ?

I don't think it is confusing because when select all is checked, all the components will be checked. With Export Selected Components I want the user to understand that only the selected components will be exported.

Screenshot 2023-09-26 at 2 35 21 PM

@vanessuniq
Copy link
Contributor Author

Hey @vanessuniq ,
Looks good.
I have an observation - If one chose, select all then the context that Export Selected Components remains somewhat unclear. so, should we just say simply, Export (button) for the purposes of clarity ?

I don't think it is confusing because when select all is checked, all the components will be checked. With Export Selected Components I want the user to understand that only the selected components will be exported.

Screenshot 2023-09-26 at 2 35 21 PM

Also the select released components checkbox is disabled if the project has no released components.

@vanessuniq vanessuniq enabled auto-merge (squash) September 26, 2023 19:45
Copy link
Contributor

@rlakey rlakey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it as is. I checked it out in the test deployment and I think that'll work for me.

@vanessuniq vanessuniq merged commit 3b00a2d into master Sep 26, 2023
1 check passed
@vanessuniq vanessuniq deleted the export_excel_update branch September 26, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Pull requests that add a new feature vmw
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Vulcan container crashes when exporting to excel
3 participants