Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sign documentation is wrong #109

Closed
tomasiser opened this issue Oct 13, 2020 · 1 comment
Closed

sign documentation is wrong #109

tomasiser opened this issue Oct 13, 2020 · 1 comment

Comments

@tomasiser
Copy link
Member

tomasiser commented Oct 13, 2020 •
edited
Loading

Hello, in the reference documentation, there is a very weird definition of the signum function for sign that does not return -1:

image

However, when you actually use the function, it returns -1 just fine, as per the definition of std::copysign.

Can also be reproduced in Python:
image
@wjakob wjakob closed this as completed Oct 17, 2020
@wjakob
Copy link
Member

wjakob commented Oct 17, 2020

fixed via #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wjakob @tomasiser