Add support for binds parameter to session #168
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for this. I had to override the |
|
FWIW, this last test doesn't fail for me on Python 3.4 and master with this pull request applied. Seems good to merge to me |
svenstaro
pushed a commit
to mymun/flask-sqlalchemy
that referenced
this pull request
Nov 18, 2014
Closed
|
Any update on getting this merge in? |
|
Resolved by the merge of #249 |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows one to pass
bindsparameter to the signaling session. My use case for this is that I want to override the binds in tests with connections wrapped in a transaction so that I can rollback the transaction in test teardown, which will make the tests run faster.