Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: The use of self.hparams.batch_size in the validation_step function. #599

Closed
Arch-W opened this issue May 1, 2024 · 1 comment
Closed

Comments

@Arch-W
Copy link
Contributor

Arch-W commented May 1, 2024

Hello, I'm new to contributing to open-source projects, but I believe I've identified a minor bug in the logging process.

The bug occurs in the validation_step function due to self.hparams.batch_size.
Here is my proposed solution: simply change self.hparams.batch_size to self.hparams.hyper_params["batch_size"].
I'm not familiar with the entire codebase, but this resolved my issue.

I have already submitted a PR.

@Arch-W
Copy link
Contributor Author

Arch-W commented May 1, 2024

Fixed #598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants