Refactor react-lottie to react-lottie-player #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for parthmittal ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks! Looks good. I have refactored the lotties to use the new player. Will push soon |
mateusabelli
changed the title
|
Thanks so much for this again! 💙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to solve the NPM issue caused by some packages as mentioned in this comment
The
react-lottiehas been replaced byreact-lottie-player. The animations and NPM are now working properly.I've also found an unused (
redbox-react) package that was throwing the the same incompatibility errors and removed it. Please let me know what do you think.