Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nokogiri dependency #38

Merged
merged 2 commits into from
Jun 9, 2023
Merged

update nokogiri dependency #38

merged 2 commits into from
Jun 9, 2023

Conversation

jonathanzong
Copy link
Member

i had trouble getting this site running locally because i had errors installing nokogumbo. however nokogumbo was merged into nokogiri in 1.12 (sparklemotion/nokogiri#2204). i was able to fix my install issues by replacing the nokogumbo dependency with nokogiri, '~> 1.12'

i would probably check this on your local before merging though because what even is ruby dependencies

@jonathanzong jonathanzong requested a review from arvind May 23, 2023 22:10
@alundgard
Copy link
Member

Seconding this. I also had issues locally and resolved by removing nokogumbo.

@arvind arvind merged commit 7b75b88 into main Jun 9, 2023
@arvind arvind deleted the jzong/nokogiri branch June 9, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants