Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix access control #6

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Fix access control #6

merged 1 commit into from
Nov 12, 2018

Conversation

morishin
Copy link
Contributor

@morishin morishin commented Nov 10, 2018 •
edited
Loading

Problem

2018-11-11 2 03 17

(Xcode 10.1, Swift 4.2.1)

Solution

  • Make public struct properties explicitly

Reference

The structure’s members (including the numberOfEdits property) therefore have an internal access level by default.
https://docs.swift.org/swift-book/LanguageGuide/AccessControl.html#ID18

Please review 🙏 @miup

@miup
Copy link
Owner

miup commented Nov 12, 2018

LGTM👍
Thanks!

@miup miup merged commit 33c85a9 into miup:master Nov 12, 2018
@morishin morishin deleted the fix-access-control branch November 12, 2018 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morishin @miup