Update for nan@2 #16
Merged
Update for nan@2 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its actually not needed since Handles are Locals now See nodejs/nan#401 Local<Value> cannot be newed since Value is the base class.
|
Maybe you should add |
|
This is related to #17. |
Add sudo: false to use new infrastructure
* Inspired by https://github.com/sematext/spm-agent-nodejs/blob/master/.travis.yml * io.js new Nan configuration now requires g++ 4.8 or clang++ 3.4
|
Thanks @gordalina for the suggestion. I have included iojs-v3.1.0 which electron depends on currently. v4 is not out yet. In the process, I have migrated the travis run to the new docker-based infrastructure (by specifying On to @mivion for further approval. |
|
Thanks for grate work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, followed this snippet, as well as manually changed all the String Initializers to have
ToLocalCheckedas suggested on the same thread.In addition to node v0.12.7, I tested this with electron/iojs:
"electron-prebuilt": "^0.32.2".npm testruns fine. If interested in compiling against electron/iojs, see this script.