added error handler when making request call. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have had/seen this issue too. I agree with the suggested pull request. You can see this issue here - http://stackoverflow.com/questions/21957258/socket-hang-up-error-with-multiple-http-get-requests. Please test, merge and release :) |
|
This seems like quite a common issue as I am experiencing it too, we could really use this fix being included in a new release :) |
|
This lgtm. Thanks! @jamesmhaley I have merge access, but not npm publish access. Can you merge this and publish? |
|
Sorry for the delay, been on another project. @bradvogel you now have npm access. |
|
Published as 2.0.2 - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will catch any socket error such as DNS, timeout, or IO errors.