Deprecate getConditionMap, add toString, remove/add

[mericsson]

No description provided.

[bradvogel]

shouldn't this also escape double quotes? ie replace " with \"

[mericsson]

Yes, nice catch. Just noticed it myself. On Tue, Oct 10, 2017 7:41 PM, Brad Vogel notifications@github.com wrote: @bradvogel commented on this pull request.

-------------------------------------------------------------------------------- In src/searchString.js:

+ this.conditionArray.forEach(({ keyword, value, negated }) => {

+ const negatedStr = negated ? '-' : ''; + const conditionGroupKey = `${negatedStr}${keyword}`; + if (conditionGroups[conditionGroupKey]) { + conditionGroups[conditionGroupKey].push(value); + } else { + conditionGroups[conditionGroupKey] = [value]; + } + }); + // Build conditionStr + let conditionStr = ''; + Object.keys(conditionGroups).forEach((conditionGroupKey) => { + const values = conditionGroups[conditionGroupKey]; + const safeValues = values + .filter((v) => v) + .map((v) => (v.indexOf(' ') > 0 || v.indexOf(',') > 0 ? `"${v}"` : v)); shouldn't this also escape double quotes? ie replace " with \" — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.