Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new tab whisper mode #80

Merged
merged 5 commits into from
Aug 31, 2020

Conversation

mixxorz
Copy link
Owner

@mixxorz mixxorz commented Aug 30, 2020

Issue ticket #54, #50

If applied, this PR will...
Add support for the New Tab whisper mode. This also adds support for the Pet Battle tab.

Please provide detail on the technical changes, if relevant
This PR modifies SlidingMessageFrame and ChatTab to allow for reuse.

  • Add CreateSlidingMessageFramePool

Screenshots

Screen Shot 2020-08-31 at 1 04 23 PM

Dev checklist

  • Feature works with other addons enabled
  • Feature works with all other addons disabled
  • README updated (if necessary)
  • CHANGELOG updated

@mixxorz mixxorz merged commit f0c5cfa into master Aug 31, 2020
@mixxorz mixxorz deleted the feature/54-handle-temporary-tabs branch August 31, 2020 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant