Add support for third-party chat links #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixxorz
changed the title
mixxorz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue ticket #89, #32
If applied, this PR will...
Add support for other addon's chat links. This includes Prat's URL links and Mythic Dungeon Tool's route links.
Please provide detail on the technical changes, if relevant
The thing preventing this was a local reference to
SetItemRef. At the point when Glass loads,SetItemRefpoints to the original function. But other addons hook and replaceSetItemRefto add their own links. The change is simply to use the global reference_G.SetItemRefinstead of creating a local reference.Dev checklist