Remove unecessary invocations of CMake #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works for me too on Windows 8.1, everything compiles fine. |
Closed
|
thanks a lot @default-kramer -- I'm upgrading taglib to 1.10 and in the process used |
rryan
force-pushed
the
windows_environment
branch
from
6cd5216
to
a8ef711
Compare
|
Thanks again for the PR -- this is quite out of date now and we've gone with the build environment running cmake for these jobs every time you build instead of creating solutions and checking them in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just built Mixxx from scratch on a fresh Win7 machine with these changes and everything worked.