Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove no longer existing CO num_effects from manual #564

Merged
merged 2 commits into from Jun 18, 2023
Merged

Remove no longer existing CO num_effects from manual #564

merged 2 commits into from Jun 18, 2023

Conversation

JoergAtGithub
Copy link
Member

@JoergAtGithub JoergAtGithub commented Jun 3, 2023 •
edited

@JoergAtGithub
Remove redundant CO documentation using no longer existing num_effects
41f9bcb 
Fixed range using num_effects where num_effectsslot is correct
Swiftb0y
Swiftb0y approved these changes Jun 3, 2023
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@Swiftb0y
Copy link
Member

Swiftb0y commented Jun 3, 2023

fyi this branch still suffers from build issues due to #559

@JoergAtGithub
Copy link
Member Author

Build fails (also) due to a corrupt changelog, which mixbot copied from mixxxdj/mixxx: #553

@Swiftb0y Swiftb0y merged commit 17be59a into mixxxdj:2.4 Jun 18, 2023
10 checks passed
@JoergAtGithub JoergAtGithub deleted the remove_num_effects branch June 18, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoergAtGithub @Swiftb0y