DEBUG_ASSERT: Reimport file tags with Serato cues

[mixxxbot]

Reported by: uklotzde
Date: 2020-07-20T22:10:10Z
Status: New
Importance: Low
Launchpad Issue: lp1888321
Tags: metadata

---

Debug [Main]: Reading cues from 'Serato Markers2' tag data...
Critical [Main]: DEBUG ASSERT: "!m_pCueInfoImporterPending->isEmpty()" in function void Track::importPendingCueInfosMarkDirtyAndUnlock(QMutexLocker*) at /tmp/mixxx/src/track/track.cpp:996


mixxxdj/mixxx#4914  0x0000000000498cc4 in mixxx_debug_assert(char const*, char const*, int, char const*)
    (assertion=assertion@entry=0xe99ae8 "!m_pCueInfoImporterPending->isEmpty()", file=file@entry=0xe99490 "/tmp/mixxx/src/track/track.cpp", line=line@entry=996, function=function@entry=0xe99aa0 "void Track::importPendingCueInfosMarkDirtyAndUnlock(QMutexLocker*)") at /usr/include/qt5/QtCore/qlogging.h:90
mixxxdj/mixxx#4915  0x00000000004acb78 in mixxx_maybe_debug_assert_return_true(char const*, char const*, int, char const*)
    (function=0xe99aa0 "void Track::importPendingCueInfosMarkDirtyAndUnlock(QMutexLocker*)", line=996, file=0xe99490 "/tmp/mixxx/src/track/track.cpp", assertion=0xe99ae8 "!m_pCueInfoImporterPending->isEmpty()") at /tmp/mixxx/src/util/assert.h:16
mixxxdj/mixxx#4916  Track::importPendingCueInfosMarkDirtyAndUnlock(QMutexLocker*) (this=0x7ffeec12abf0, pLock=0x7fffffffbae0) at /tmp/mixxx/src/track/track.cpp:996
mixxxdj/mixxx#4917  0x00000000006836bb in Track::importCueInfos(std::shared_ptr<mixxx::CueInfoImporter>)
    (this=0x7ffeec12abf0, pCueInfoImporter=std::shared_ptr<mixxx::CueInfoImporter> (use count 2, weak count 0) = {...}) at /tmp/mixxx/src/track/track.cpp:915
mixxxdj/mixxx#4918  0x0000000000683cef in Track::importMetadata(mixxx::TrackMetadata, QDateTime) (this=this@entry=0x7ffeec12abf0, importedMetadata=..., metadataSynchronized=...)
    at /tmp/mixxx/src/track/track.cpp:186
mixxxdj/mixxx#4919 0x0000000000661e37 in SoundSourceProxy::updateTrackFromSource(SoundSourceProxy::ImportTrackMetadataMode)
    (this=this@entry=0x7fffffffc060, importTrackMetadataMode=importTrackMetadataMode@entry=SoundSourceProxy::ImportTrackMetadataMode::Again) at /tmp/mixxx/src/tagging/customtags.h:50
mixxxdj/mixxx#4920 0x0000000000cad96c in (anonymous namespace)::ImportMetadataFromFileTagsTrackPointerOperation::doApply(TrackPointer const&) const (this=<optimized out>, pTrack=...)
    at /usr/include/c++/10/ext/atomicity.h:100
mixxxdj/mixxx#4921 0x0000000000b3a187 in mixxx::TrackPointerOperation::apply(std::shared_ptr<Track> const&) const (pTrack=std::shared_ptr<Track> (use count 33, weak count 1) = {...}, this=<optimized out>)
    at /tmp/mixxx/src/library/trackprocessing.h:89
mixxxdj/mixxx#4922 mixxx::ModalTrackBatchOperationProcessor::doProcessNextTrack(std::shared_ptr<Track> const&) (pTrack=std::shared_ptr<Track> (use count 33, weak count 1) = {...}, this=0x7fffffffc230)
    at /tmp/mixxx/src/library/trackprocessing.cpp:109
mixxxdj/mixxx#4923 mixxx::ModalTrackBatchProcessor::processTracks(QString const&, TrackCollectionManager*, mixxx::ItemIterator<std::shared_ptr<Track> >*)
    (this=this@entry=0x7fffffffc230, progressLabelText=..., pTrackCollectionManager=0x3365af0, pTrackPointerIterator=0x9d948f0) at /tmp/mixxx/src/library/trackprocessing.cpp:57
mixxxdj/mixxx#4924 0x0000000000cb00d4 in WTrackMenu::applyTrackPointerOperation(QString const&, mixxx::TrackPointerOperation const*, mixxx::ModalTrackBatchOperationProcessor::Mode) const
    (this=0x1190a450, progressLabelText=..., pTrackPointerOperation=0x7fffffffc298, operationMode=mixxx::ModalTrackBatchOperationProcessor::Mode::ApplyAndSave)
    at /usr/include/c++/10/bits/unique_ptr.h:420
mixxxdj/mixxx#4925 0x0000000000cb0193 in WTrackMenu::slotImportMetadataFromFileTags() (this=0x1190a450) at /tmp/mixxx/src/widget/wtrackmenu.cpp:907

[mixxxbot]

Commented by: uklotzde
Date: 2020-07-20T22:16:04Z

---

m_pCueInfoImporterPending is empty if the file doesn't contain any Serato cues. Do we need to check for this earlier or replace the VERIFY_OR_DEBUG_ASSERT with a regular if condition?

[mixxxbot]

Commented by: Be-ing
Date: 2021-03-08T20:43:39Z

---

Is this still an issue?