-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Waveform or Grid drifting after zoom #10300
Comments
Commented by: kek001 This is an other problematic grid behaviour https://mixxx.discourse.group/t/mixxx-2-3-beta-grid-wobble/21117 |
Commented by: daschuer I can reproduce the issue by disabling zoom sync in the waveform preferences. We may improve the situation by Snapping the zoom into sync when coming close. However, is the non synced state a valid use case for parallel Waveforms? Is the issue solved for you by enabling the zoom sync? If yes, I like to close this bug. |
Commented by: kek001 Using the zoom sync helps for the first problem. But it wont help second problem. Where grid is drifting without zooming. It happends when you load track, it looks fine first minute, but end of track or 2/3 First problem its strange the zoom method cant restore orginal state before using zoom, and messing with scale. So enabling zoom for all tracks sync will not solve the error. |
Commented by: kek001 for me second problem it looks some point the grid or waveform shrink or expands. |
Commented by: daschuer Do you use constant beat grids (default)? Does the issue change without changing the beat grid or is the order the same whenever you seek to that off beat position? I think we have a rounding bug in the constant beat grid calculation. Maybe you are seeing this. Is the issue gone when you reset the best grid and reanalyze it with the conts flag removed (beat detection preferences)? Can you point me to a significant track that suffers the issue? I can use it to test the rounding code fix. |
Commented by: kek001 Yes I do use Constant by default. Q:"Does the issue change without changing the beat grid or is the order the same whenever you seek to that off beat position?" A: Sorry I dont understand. I was thinking it can be rounding or declaration or type. |
Commented by: daschuer The question is if we can assume that it is an issue of the analysis date that persists as long as the beat-grid is not adjusted manually, of if it is a visual issue that is floating around depending on waveformnams skin settings. |
Commented by: kek001 Ok. Thank you. For first problem, zooming in out. I think its visual. Second problem, i will triple check and create 8 min constant beat mp3 track, so i can be sure |
Commented by: kek001 I have tried find logic for the second problem. I check about 20 tracks and i often found the grid is 0.01 - 0.02 off from beat, even i tried to assign it again. Now my head is jelly, will continue tomo .... |
Commented by: kek001 I created long mp3 files using joint stereo , stereo and created by lame 3.99r and Sony Acid. mpeg III The mp3 are very simple repeating Kick Drum, i dont know is it too simple and should I add more artifacts, which can cause differencies while lame packs mp3 file. I can't reproduce 0.01- 0.02 off from grid. It makes me scratch my head, Because yesterday, i pick up randomly 20 tracks from my set, and saw allmost all had shift from grid. and the ammount were same, and the track should be constant beat, For the first problem enabling sync zoom with all decks, is somekind of solution, but it will leave "rounding" scale restore issuer.. I have to think thank second problem, so if you can give me time end of this week, before closing this topic. |
Commented by: daschuer Another cause of drifting waveforms are discontinues due to decoding issues. When this happens, the sound is out of sync, while the beat-grof is still on the waveforms. |
Commented by: kek001 I was testing some tracks in DJuced and Mixxx 2.2.3, my traktor machine is not near me now. Mixxx 2.2.3 is working well and DJuced is working well and grid positions are right place. This is not only visual thing, i test it. Sometimes kick or hihat is missing or its playing part of Kick while i am jumping to hotcue. About month ago i was thinking whats going on and have to record one set five times because of this. Thinking whats going on, cant be so bad after half year pause, because there was odd sounds while jumping hotcues. Now I am wondering why simple 14 min Kick.mp3 (lame 3.99) and an other one created by Sony Acid. I try to check and think more at saturday. |
Commented by: kek001 While trying to find free track, Check attachment image and here is track. |
Commented by: kek001 From same album you can check a track Green Path. Grids goes well 2.2.3 but not 2.3beta. |
Commented by: daschuer Cool Thank you very much. Which encoding did you test? Is one of the other encoding also affected? |
Commented by: kek001 I am not sure about, but i think it doesnt matter what encoder, or is joint or stereo. what I tested for my own plain kick. I will test and check more. |
Commented by: kek001 I was using mp3 file from ektoplazm. I will download flac and check how that will behave. |
Commented by: kek001 Green Path flac file has correct Grid placement in Mixxx 2.3 beta ! |
Commented by: daschuer Thank you for confirming. By the way, I have a pending PR that aims to remove the static offset of the detected beat grid. Do you have interests to test this? #3626 |
Commented by: kek001 Hi Thank you for reply. Sure I would like to test it. |
Commented by: kek001 Can I use this for test it. Index of /builds/2.3/Windows Mixxx-2.3-r8012-b8bb1bb8ae.msi 2021-02-13 16:02 94M |
Commented by: kek001 I meant the flac version of the track is working well, but not mp3, so it can't be the track Green Path has variable tempo. So this issue still has problem and is active. |
Commented by: daschuer This is the link to the windows installer of the version with improved offset correction: I think you need to be logged in on GitHub to make the link work. Let's move the rest of our conversation to GitHub to not clutter this bug more. |
This should be fixed with Mixxx 2.3 please reopen if this is not the case. |
Reported by: kek001
Date: 2021-01-24T13:14:59Z
Status: In Progress
Importance: High
Launchpad Issue: lp1912942
Tags: beatgrid, waveform
Attachments: 23beta_vs_223
Mixxx 2.3 beta, windows 10
After using zoom, other decks are out of "sync"
Waveform or grid is drfting.
https://mixxx.discourse.group/t/strange-grid-behaviour-2-3-beta/21035
The text was updated successfully, but these errors were encountered: