DEBUG ASSERT in effects_refactoring branch

[mixxxbot]

Reported by: daschuer
Date: 2021-10-18T16:39:53Z
Status: Fix Committed
Importance: Undecided
Launchpad Issue: lp1947615

---

I was able to catch a back trace of it:

critical[Main] DEBUG ASSERT: "pModel" in function void DlgPrefEffects::effectsTableItemSelected(const QModelIndex&) at /home/daniel/workspace/i18n/src/preferences/dialog/dlgprefeffects.cpp:169

#0  raise (sig=<optimized out>) at ../sysdeps/unix/sysv/linux/raise.c:50
mixxxdj/mixxx#4910  0x00007ffff347c1f8 in qt_message_print(QtMsgType, QMessageLogContext const&, QString const&) (msgType=QtCriticalMsg, context=..., message=...) at global/qlogging.cpp:1836
mixxxdj/mixxx#4911  0x00007ffff347c319 in qt_message(QtMsgType, const QMessageLogContext &, const char *, typedef __va_list_tag __va_list_tag *) (msgType=QtCriticalMsg, context=..., msg=<optimized out>, ap=<optimized out>) at global/qlogging.cpp:373
mixxxdj/mixxx#4912  0x00007ffff344b6cc in QMessageLogger::critical(char const*, ...) const (this=this@entry=0x7fffffffc7b0, msg=msg@entry=0x55555625ea88 "%s: \"%s\" in function %s at %s:%d") at global/qlogging.cpp:767
mixxxdj/mixxx#4913  0x00005555556602df in mixxx_debug_assert(char const*, char const*, int, char const*) (assertion=assertion@entry=0x555556310448 "pModel", file=file@entry=0x5555563102b0 "/home/daniel/workspace/i18n/src/preferences/dialog/dlgprefeffects.cpp", line=line@entry=169, function=function@entry=0x555556310268 "void DlgPrefEffects::effectsTableItemSelected(const QModelIndex&)") at /usr/include/x86_64-linux-gnu/qt5/QtCore/qlogging.h:91
mixxxdj/mixxx#4914  0x0000555555705de6 in mixxx_debug_assert_return_true(char const*, char const*, int, char const*) (function=0x555556310268 "void DlgPrefEffects::effectsTableItemSelected(const QModelIndex&)", line=169, file=0x5555563102b0 "/home/daniel/workspace/i18n/src/preferences/dialog/dlgprefeffects.cpp", assertion=0x555556310448 "pModel") at /home/daniel/workspace/i18n/src/util/assert.h:18
mixxxdj/mixxx#4915  DlgPrefEffects::effectsTableItemSelected(QModelIndex const&) (this=<optimized out>, selected=...) at /home/daniel/workspace/i18n/src/preferences/dialog/dlgprefeffects.cpp:169
mixxxdj/mixxx#4916  0x00007ffff3678458 in QtPrivate::QSlotObjectBase::call(QObject*, void**) (a=0x7fffffffc920, r=0x555562a9a670, this=0x555562ac0bc0) at ../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:394
mixxxdj/mixxx#4917  QMetaObject::activate(QObject*, int, int, void**) (sender=0x555562ac1bd0, signalOffset=<optimized out>, local_signal_index=<optimized out>, argv=<optimized out>) at kernel/qobject.cpp:3784
mixxxdj/mixxx#4918  0x00007ffff3608087 in QItemSelectionModel::currentRowChanged(QModelIndex const&, QModelIndex const&) (this=this@entry=0x555562ac1bd0, _t1=..., _t2=...) at .moc/moc_qitemselectionmodel.cpp:472
mixxxdj/mixxx#4919 0x00007ffff3610897 in QItemSelectionModelPrivate::_q_rowsAboutToBeRemoved(QModelIndex const&, int, int) (this=0x555562ac2000, parent=..., start=0, end=19) at itemmodels/qitemselectionmodel.cpp:737
mixxxdj/mixxx#4920 0x00007ffff3612826 in QItemSelectionModel::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (_o=<optimized out>, _c=<optimized out>, _id=<optimized out>, _a=0x7fffffffcc30) at itemmodels/qitemselectionmodel.h:148
mixxxdj/mixxx#4921 0x00007ffff3678300 in QMetaObject::activate(QObject*, int, int, void**) (sender=0x555562abf670, signalOffset=<optimized out>, local_signal_index=<optimized out>, argv=<optimized out>) at kernel/qobject.cpp:3804
mixxxdj/mixxx#4922 0x00007ffff35f8d22 in QAbstractItemModel::rowsAboutToBeRemoved(QModelIndex const&, int, int, QAbstractItemModel::QPrivateSignal) (this=this@entry=0x555562abf670, _t1=..., _t2=<optimized out>, _t2@entry=0, _t3=<optimized out>, _t3@entry=19, _t4=...) at .moc/moc_qabstractitemmodel.cpp:598
mixxxdj/mixxx#4923 0x00007ffff3600e1c in QAbstractItemModel::beginRemoveRows(QModelIndex const&, int, int) (this=this@entry=0x555562abf670, parent=..., first=first@entry=0, last=last@entry=19) at itemmodels/qabstractitemmodel.cpp:2790
mixxxdj/mixxx#4924 0x0000555555ab4a86 in EffectManifestTableModel::removeRows(int, int, QModelIndex const&) (this=0x555562abf670, row=0, count=<optimized out>, parent=...) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qabstractitemmodel.h:60
mixxxdj/mixxx#4925 0x0000555555ab4204 in EffectManifestTableModel::setList(QList<QSharedPointer<EffectManifest> > const&) (this=0x555562abf670, newList=...) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qlist.h:170
mixxxdj/mixxx#4926 0x0000555555eb8186 in DlgPrefEffects::slotUpdate() (this=0x555562a9a670) at /home/daniel/workspace/i18n/src/preferences/dialog/dlgprefeffects.cpp:95
mixxxdj/mixxx#4927 0x0000555555a5c902 in DlgPreferences::slotButtonPressed(QAbstractButton*) (this=0x55555771cee0, pButton=<optimized out>) at /home/daniel/workspace/i18n/src/preferences/dialog/dlgpreferences.cpp:388

This has happens after clicking on the "Restore defaults" button in the effect preferences.
Resuming is possible without a crash.

[mixxxbot]

Commented by: daschuer
Date: 2021-10-19T22:18:40Z

---

The same assertion happens reproducible if I try to make all hidden effects visible at one.
By dragging all from the hidden effects to the visible effects.

This happens also if you make one effect visible and than close and reopen the preferences window.

[mixxxbot]

Commented by: ronso0
Date: 2021-10-22T10:29:26Z

---

#4468

[mixxxbot]

Commented by: ronso0
Date: 2021-10-22T22:17:41Z

---

oh, I should probably restore ExtendedSelection for the effect list to re-enable dragging multiple effects/chains. But we'd need to clear the effect/chain info table then.

[mixxxbot]

Issue closed with status Fix Committed.