Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSVC][std:c++latest] Mixxx failed to build with /std:c++latest on MSVC #10627

Open
mixxxbot opened this issue Aug 23, 2022 · 2 comments
Open

Comments

@mixxxbot
Copy link
Collaborator

Reported by: quellazhang
Date: 2021-12-30T06:23:06Z
Status: Confirmed
Importance: Low
Launchpad Issue: lp1956018


Mixxx failed to build with /std:c++latest on MSVC. Could you please help look at this issue or provide some workarounds? Thanks in advance.

Build steps:
git clone https://github.com/mixxxdj/mixxx F:\gitP\mixxxdj\mixxx
set _CL_= /std:c++latest
mkdir F:\gitP\mixxxdj\mixxx\buildenv && cd F:\gitP\mixxxdj\mixxx\buildenv
set PATH=F:\tools\build2\bin;%PATH%
curl https://downloads.mixxx.org/dependencies/2.4/Windows/mixxx-deps-2.4-x64-windows-058063e.zip -O -L
cd F:\gitP\mixxxdj\mixxx\tools
SET PLATFORM=x64
SET CONFIGURATION=release
windows_buildenv.bat
mkdir F:\gitP\mixxxdj\mixxx\build
cd F:\gitP\mixxxdj\mixxx\build
cmake -DBULK=OFF -DFFMPEG=OFF -DHSS1394=ON -DLOCALECOMPARE=ON -DMAD=ON -DMEDIAFOUNDATION=ON -DMODPLUG=ON -DWAVPACK=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_PREFIX_PATH="" -DDEBUG_ASSERTIONS_FATAL=OFF -DBATTERY=ON -DBROADCAST=ON -DDOWNLOAD_MANUAL=ON -DHID=ON -DKEYFINDER=ON -DLILV=ON -DOPUS=ON -DQTKEYCHAIN=ON -DVINYLCONTROL=ON -DCMAKE_VERBOSE_MAKEFILE=OFF -L ..
cmake --build . --config Release --verbose > build.log

Error info:
cl : Command line warning D9025 : overriding '/std:c++17' with '/std:c++latest'
..\lib\xwax\timecoder_win32.cpp(59): error C2440: 'initializing': cannot convert from 'const char [10]' to 'char *'
..\lib\xwax\timecoder_win32.cpp(59): note: Conversion from string literal loses const qualifier (see /Zc:strictStrings)
..\lib\xwax\timecoder_win32.cpp(60): error C2440: 'initializing': cannot convert from 'const char [23]' to 'char *'
..\lib\xwax\timecoder_win32.cpp(60): note: Conversion from string literal loses const qualifier (see /Zc:strictStrings)
..\lib\xwax\timecoder_win32.cpp(71): error C2440: 'initializing': cannot convert from 'const char [10]' to 'char *'
..\lib\xwax\timecoder_win32.cpp(71): note: Conversion from string literal loses const qualifier (see /Zc:strictStrings)
..\lib\xwax\timecoder_win32.cpp(72): error C2440: 'initializing': cannot convert from 'const char [23]' to 'char *'
..\lib\xwax\timecoder_win32.cpp(72): note: Conversion from string literal loses const qualifier (see /Zc:strictStrings)
..\lib\xwax\timecoder_win32.cpp(83): error C2440: 'initializing': cannot convert from 'const char [10]' to 'char *'
..\lib\xwax\timecoder_win32.cpp(83): note: Conversion from string literal loses const qualifier (see /Zc:strictStrings)
..\lib\xwax\timecoder_win32.cpp(84): error C2440: 'initializing': cannot convert from 'const char [10]' to 'char *'
..\lib\xwax\timecoder_win32.cpp(84): note: Conversion from string literal loses const qualifier (see /Zc:strictStrings)
..\lib\xwax\timecoder_win32.cpp(95): error C2440: 'initializing': cannot convert from 'const char [10]' to 'char *'
@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2021-12-30T12:48:51Z


The issue is here in one of our external libraries:

It can be fixed by adding "const" here:

char *name, *desc;

Out of curious, why do you set /std:c++latest?

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2021-12-30T13:12:23Z


I have reported is at [xwax-devel]

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant