"skin:" path problem: base files cannot be included into custom skin by "skin:path/to/template"

[mxmilkiib]

Bug Description

If you reference/include a theme file that's back in the theme base dir by using "skin:", then if that base file uses "skin:", the path is incorrect.

Temp fix is to copy files to subtheme replace some of the "skin:" with "skins:/Basetheme".

...
warning [Main] LegacySkinParser::loadTemplate - setContent failed see "/home/milk/.mixxx/skins/Deere-RekboxHighwave/skin:left_right_1state_button.xml" line: 0 column: 0
warning [Main] LegacySkinParser::loadTemplate - message: "QDomDocument::setContent: Failed to open device."
warning [Main] Skin parsing failed at skins:Deere/deck_looping_controls.xml:56 <Template>: Template instantiation for template failed: skin:left_right_1state_button.xml | ./src/skin/legacy/legacyskinparser.cpp:1735
warning [Main] Could not open template file: "/home/milk/.mixxx/skins/Deere-RekboxHighwave/skin:left_right_1state_button.xml"
warning [Main] QDomDocument called with unopened QIODevice. This will not be supported in future Qt versions.
warning [Main] QDomDocument::setContent: Failed to open device.

warning [Main] LegacySkinParser::loadTemplate - setContent failed see "/home/milk/.mixxx/skins/Deere-RekboxHighwave/skin:left_right_1state_button.xml" line: 0 column: 0
warning [Main] LegacySkinParser::loadTemplate - message: "QDomDocument::setContent: Failed to open device."
warning [Main] Skin parsing failed at skins:Deere/deck_looping_controls.xml:72 <Template>: Template instantiation for template failed: skin:left_right_1state_button.xml | ./src/skin/legacy/legacyskinparser.cpp:1735
warning [Main] Could not open template file: "/home/milk/.mixxx/skins/Deere-RekboxHighwave/skin:left_right_2state_button.xml"
warning [Main] QDomDocument called with unopened QIODevice. This will not be supported in future Qt versions.
warning [Main] QDomDocument::setContent: Failed to open device.
...

Version

2.4-beta

OS

Linux

[ronso0]

Hmm, this reveals multiple issues:

1. mass-replace in Skins: add skins: path alias #12463 missed a lot of <Template src="skin: occurences
2. stylesheets also need to use skins:[skin name]
3. clarify that sub-level templates are not magically detected, i.e. the instructions how mod an official skin with minimal effort need to be completed
4. same for icons/style mods

[ronso0]

Fixed by #12621