Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibaryScanner on program-start extremely slows down program #5452

Closed
mixxxbot opened this issue Aug 22, 2022 · 10 comments
Closed

LibaryScanner on program-start extremely slows down program #5452

mixxxbot opened this issue Aug 22, 2022 · 10 comments
Labels

Comments

@mixxxbot
Copy link
Collaborator

Reported by: florian-itzoo
Date: 2010-07-10T15:35:43Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp604018


When Mixxx starts, the LibraryScanner slows down the program. The usage of the program is possible, when the scan is finished.
This is not very reliable, when mixxx has to be restarted because of a crash. i have to wait 4 minutes until the library-scan is finished.

Maybe its possible to open a status-window while resanning with options to pause, abort or nice the scanprocess.

[...]
Debug: [Main]: Displaying mixxx 
Debug: [Main]: Running Mixxx 
Debug: [LibraryScanner 1]: Recursively scanning library. 
Debug: [LibraryScanner 1]: Recursive scan finished cleanly. 
Debug: [LibraryScanner 1]: Marking unverified tracks as deleted. 
Debug: [LibraryScanner 1]: Detecting moved files. 
Debug: [LibraryScanner 1]: Scan finished cleanly 
Debug: [LibraryScanner 1]: Scan took: 255761 ms
[...]

version-info:
revision-id: <email address hidden>
date: 2010-06-28 13:57:19 +0200
build-date: 2010-07-10 15:09:36 +0200
revno: 2430
branch-nick: mixxx

pc-infos:
Linux laptop 2.6.32-23-generic #⁠37-Ubuntu SMP Fri Jun 11 08:03:28 UTC 2010 x86_64 GNU/Linux
Ubuntu 10.04 LTS (lucid)
Audio devices: nVidia Corporation MCP67 High Definition Audio (rev a1) & C-Media Electronics, Inc. Audio Adapter

@mixxxbot
Copy link
Collaborator Author

Commented by: asantoni
Date: 2010-07-11T05:30:44Z


Hi Florian,

Can you tell us a little bit about your music library? How big is it?
How fast is your laptop?

Thanks,
Albert

2010/7/10 Florian Schrön :

Public bug reported:

When Mixxx starts, the LibraryScanner slows down the program. The usage of the program is possible, when the scan is finished.
This is not very reliable, when mixxx has to be restarted because of a crash. i have to wait 4 minutes until the library-scan is finished.

Maybe its possible to open a status-window while resanning with options
to pause, abort or nice the scanprocess.

[...]
Debug: [Main]: Displaying mixxx
Debug: [Main]: Running Mixxx
Debug: [LibraryScanner 1]: Recursively scanning library.
Debug: [LibraryScanner 1]: Recursive scan finished cleanly.
Debug: [LibraryScanner 1]: Marking unverified tracks as deleted.
Debug: [LibraryScanner 1]: Detecting moved files.
Debug: [LibraryScanner 1]: Scan finished cleanly
Debug: [LibraryScanner 1]: Scan took: 255761 ms
[...]

version-info:
revision-id:
date: 2010-06-28 13:57:19 +0200
build-date: 2010-07-10 15:09:36 +0200
revno: 2430
branch-nick: mixxx

pc-infos:
Linux laptop 2.6.32-23-generic #⁠37-Ubuntu SMP Fri Jun 11 08:03:28 UTC 2010 x86_64 GNU/Linux
Ubuntu 10.04 LTS (lucid)
Audio devices: nVidia Corporation MCP67 High Definition Audio (rev a1) & C-Media Electronics, Inc. Audio Adapter

** Affects: mixxx
    Importance: Undecided
        Status: New

--
LibaryScanner on program-start extremely slows down program
https://bugs.launchpad.net/bugs/604018
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.

@mixxxbot mixxxbot added the bug label Aug 22, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: florian-itzoo
Date: 2010-07-11T17:30:33Z


Hi albert,

the library is 64GB big and contains 15833 mp3-files.

the laptop is a hp pavillion with a AMD Turion(tm) 64 X2 Mobile Technology TL-58 and 2GB RAM.

Greetings,
Florian

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2010-09-11T09:15:19Z


4 minutes on a 15k files is not terrible, thats 16ms per song, which is not too bad.

Is that how long it takes on the first scan or is that how long it takes on every bootup of Mixxx?

If it's the latter, that is not good. If nothing in your library has changed, our library scanner should be able to skip over directories that have not changed.

Do you have all your music in many subdirectories or is it all in one big folder?

Thanks,
RJ

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2010-09-11T09:16:23Z


We do not set the priority of the library scanner thread, so maybe we should set it a little lower. Albert?

@mixxxbot
Copy link
Collaborator Author

Commented by: florian-itzoo
Date: 2010-09-12T19:50:35Z


I have many subdirectories.(1065)
The time for scanning is the same for fiirst and normal startup and startup after crash.

@mixxxbot
Copy link
Collaborator Author

Commented by: asantoni
Date: 2010-09-12T22:26:39Z


Hi Florian,

I've made some changes in 1.8 to lower the priority of the library
scanner, and that might improve the situation for you. Also, it's
perfectly safe to cancel the library scan half-way, at least in 1.8.

Thanks,
Albert

2010/9/12 Florian Schrön :

I have many subdirectories.(1065)
The time for scanning is the same for fiirst and normal startup and startup after crash.

--
LibaryScanner on program-start extremely slows down program
https://bugs.launchpad.net/bugs/604018
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2010-09-13T02:55:13Z


Just committed Tobias' library scan performance patch. This has increased the speed of my library by a significant amount. Scanning 75gb / 15,000 files on my SSD takes 28 seconds. After Tobias's patch, that scan now takes 4 seconds.

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2010-09-13T02:56:43Z


Also, on a library re-scan, the re-scan takes 5 seconds.

@mixxxbot
Copy link
Collaborator Author

Commented by: raffitea
Date: 2010-09-13T08:01:44Z


Cool to see that the library scanner patch is faster that 4x on SSD.

Awesome!!!

Thanks RJ for adapting and commiting my patch.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant