Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frequency kill not working when using high/low shelf eq #5498

Closed
mixxxbot opened this issue Aug 22, 2022 · 10 comments
Closed

Frequency kill not working when using high/low shelf eq #5498

mixxxbot opened this issue Aug 22, 2022 · 10 comments
Labels

Comments

@mixxxbot
Copy link
Collaborator

Reported by: esbrandt
Date: 2010-09-02T20:07:48Z
Status: Invalid
Importance: Medium
Launchpad Issue: lp629065


Mixxx 1.8.0 (bzr r2517; built on: Sep 2 2010 ; flags: hifieq vinylcontrol midiscript optimize=1 qdebug)
MacOSX 10.5.8

*Load a skin with HIGH/MID/LOW frequency kill buttons
*In Mixxx Preferences-->Equalizers deactivate the static EQs
*Load and play a track, you will notice the KILL buttons not working as expected any more

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2010-09-07T21:49:12Z


I can't seem to reproduce with the 1.8 branch. The kills work as expected with static EQs disabled. What are your frequency cutoffs set to for the high-fi eqs?

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2010-09-08T08:29:19Z


Mixxx 1.8.0 "(bzr r2395; built on: Sep  8 2010; flags: hifieq vinylcontrol midiscript optimize=2 qdebug) 
All preferences on default

Short screencast clearly illustrating the problem
http://screenr.com/HSn

Possible related bug:
https://bugs.launchpad.net/mixxx/+bug/229021

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2010-09-11T05:27:37Z


Ah I see now. Your low and high cutoffs are so close together that the high cutoff kills the whole range. My high-fi eq settings are with the high end at 2.5 kHz and the low end at 200 Hz.

Another issue though is when you pin the ranges together your volume maxes out. I've seen this before but can't reproduce it now. Are you on 32-bit or 64-bit?

If the default preferences leave the high-fi eq cutoffs so close together we should change them to something reasonable like I listed above.

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2010-09-11T08:21:57Z


Im on 32bit.

But this frequency kill behaviour might be only symptom for filter related problem Nick pointed out in 2008 (link in #⁠2) which link to an assert crash https://bugs.launchpad.net/mixxx/+bug/629053

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2010-09-11T09:35:16Z


Yea, looks like that bug is exactly what I saw in your video.

The IIR assert isn't related to this though, because the high-fi EQs don't use the IIR filters, they use Butterworth filters, which is in a different class. (it's even more computationally expensive :-/).

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2011-03-27T04:17:56Z


Hm, this one slipped through. Is it still happening?

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2011-03-27T07:15:49Z


Yes this still happens to be in trunk.
Deactivate static EQ, use the default values ( High 2.47 Khz , Low 249 Hz) and you`ll see the kill switches do not work as expected.

You can also hear a crackling sound when moving the EQ sliders in the preferences while a song is playing and no kill switch is activated.

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2012-05-08T05:18:43Z


Can you reproduce on the latest trunk? I can't (though I never could).

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2012-05-08T12:54:41Z


Can`t reproduce either.
Works fine with 1.10 final and current lp:mixxx r3100

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Invalid.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant