Clean up mutexes/locks in MIDI subsystem

[mixxxbot]

Reported by: Pegasus-RPG
Date: 2010-11-30T13:49:35Z
Status: Fix Released
Importance: High
Launchpad Issue: lp683119
Tags: deadlock, midi

---

When we originally implemented MIDI scripting, we were getting segfaults when lots of MIDI data/script functions were running. We now know that this was due to the wrong threads calling the script functions (specifically the MidiDevice thread was directly calling MidiScriptEngine functions.) At the time, we added a bunch of mutexes to the MidiScriptEngine. Once the real problem was discovered, I fixed it back in the features_HSS1394 branch by using signals/slots, but the mutexes remain and I believe are the source for any random MIDI-related deadlocks.

This bug is to remind me to remove all of those, since all MidiScriptEngine functions should only be called by the MidiScriptEngine thread. (I might add ASSERTs to ensure this.)

[mixxxbot]

Commented by: Pegasus-RPG
Date: 2010-12-01T15:47:45Z

---

This might be responsible for bug #⁠342952, so re-check that after this is fixed.

[mixxxbot]

Commented by: rryan
Date: 2011-03-26T23:27:56Z

---

Is this going to happen for 1.10.0 or should we clear the milestone?

[mixxxbot]

Commented by: Pegasus-RPG
Date: 2012-04-10T14:00:43Z

---

Fixed in controllerAbstraction, as the MIDI subsystem has been completely revamped.

[mixxxbot]

Issue closed with status Fix Released.