Resizing library table columns shows blank gaps

[mixxxbot]

Reported by: mutil
Date: 2012-02-02T18:09:45Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp925619
Attachments: screenshot.png, tracktableheader-fit.patch

---

When resizing the columns in tracktable, after a while (randomly?)
a strange gap appears between, which then can't be removed.
See attached screenshot.

This was introduced from the patch in lp:885408
where cascadingSectionResizes property was set to true.
Aside the bug, this behaviour is not really convenient, nor physical.
If you resize one column long enough all the following columns
get minimized and then you have to adjust them again.
This is not the behaviour in file browsers etc.
I believe it is useful only when you have a few columns.

[mixxxbot]

Commented by: mutil
Date: 2012-02-02T18:09:45Z
Attachments: screenshot.png

[mixxxbot]

Commented by: mutil
Date: 2012-02-02T18:17:22Z
Attachments: tracktableheader-fit.patch

---

A patch which removes setCascadingSectionResizes(true),
but adds a "Stretch columns to fit window" action
in the header menu to toggle this property and resize sections
once, to fit the window, as other music players have (e.g. clementine).

Notice that when ticked, this bug with the gaps is still there,
but at least it's not in the default behaviour.

[mixxxbot]

Commented by: ywwg
Date: 2012-02-02T20:52:45Z

---

It is possible to get rid of the gaps by reordering the columns and moving a column to the right of the gap in between the next column to the left and the gap.

This is really annoying, though.

[mixxxbot]

Commented by: gary-littlemore
Date: 2012-03-06T22:16:43Z

---

If I also change the width of one column it also reduces the width other the column next to it.

[mixxxbot]

Commented by: ronald-delvax-hotmail
Date: 2012-03-09T21:16:27Z

---

I have the same problem. It is possible to shift the empty spaces ti the beginning, but not to the end. The problem exists in Linux and windows versions of the program. Almost looks like the spaces appear when the collum reached a minimum width. You can still make the comum smaller, but the space gets bigger. I noticed that 1.8 didn't have this problem (Ubuntu installed 1.8 before I updated my repository...)

[mixxxbot]

Commented by: ronald-delvax-hotmail
Date: 2012-03-13T22:22:16Z

---

Just noticed; the blank colums cause another, more annoying problem !!!
You can shift colums to get them in front of the other colums, so you don't have blanks
within your list but: Sorting apparently is done in the FIRST COLUM...... and NOT in the colum
marked # ... This automatically implies the manually sorting the list or even use randomize
doesn't work anymore!!! Both sorting and randomize only affect the colum marked #... As this
ISN'T the first colum anymore (the first is now a blank, which can't be removed...) only the numbers
in the # colum are affected... The order in whicht songs are sorted DOES NOT CHANGE !!!

If it was just blanks, it wouldn't be much of a problem... Not being able to sort my playlists
to me is a HUGE problem... (Especially if I want to use the program professionally...)

I hope this can change the importance to something higher than low......

I'm not a super programmer... but if someone could give me the code where sorting is handled I might be able to help...

[mixxxbot]

Commented by: daschuer
Date: 2012-03-14T07:45:30Z

---

Hi Angle,

did you try multils patch againts mixxx/src/widget/wtracktableviewheader.cpp?

Which version of Ubuntu you are using? 32 or 64 bit?

Here are the files, are involved in sorting playlists:

http://bazaar.launchpad.net/~mixxxdevelopers/mixxx/release-1.10.x/view/head:/mixxx/src/widget/wtracktableviewheader.cpp
http://bazaar.launchpad.net/~mixxxdevelopers/mixxx/release-1.10.x/view/head:/mixxx/src/widget/wtracktableview.cpp
http://bazaar.launchpad.net/~mixxxdevelopers/mixxx/release-1.10.x/view/head:/mixxx/src/library/basesqltablemodel.cpp
http://bazaar.launchpad.net/~mixxxdevelopers/mixxx/release-1.10.x/view/head:/mixxx/src/library/playlisttablemodel.cpp

Here is how to compile:
http://www.mixxx.org/wiki/doku.php/compiling_on_linux

Here are some additional hints:
http://sourceforge.net/mailarchive/message.php?msg_id=28856441

If you stuck at a point don't hesitate to ask!

[mixxxbot]

Commented by: ronald-delvax-hotmail
Date: 2012-03-31T22:19:16Z

---

sry for my late reply.. been busy lately...
thnx for the file info. Havent tried any patches yet... but I'll look in to it..

I use 11.4 32 bit. Don't want to upgrade to 11.10 because I don't like the gnome 3 interface :D
Havent tried 64 bit yet...

When I removed the settings dbase, not only were the gaps gone, but sorting and randomise worked again...
confirming what I wrote earlyer...

I'll try to find a fix, but I can't promise anything ;) I'll let you know if I find anything...

[mixxxbot]

Commented by: mutil
Date: 2012-06-11T00:53:38Z

---

Could you please, at least, comment out "setCascadingSectionResizes(true)" in line 60 of wtracktableviewheader.cpp, until we find a proper solution to this?

This is a something-more-than-low importance bug for me.

When we discover a fix, we can apply the attached patch to toggle this behaviour.
But until then, something has to be done about it.

[mixxxbot]

Commented by: daschuer
Date: 2012-06-12T18:09:16Z

---

Ok, i think we hit a Qt Bug:
https://bugreports.qt-project.org/browse/QTBUG-11860

I am able to reproduce it with Qt 4.6.2, but not with Qt 6.8.1 on Linux 32bit.

[mixxxbot]

Commented by: rryan
Date: 2012-06-12T18:09:52Z

---

Hm, I tried doing that (disabling cascading section resizes) a while back
and the problem wasn't fixed for me.

On Tue, Jun 12, 2012 at 1:55 PM, Daniel Schürmann <

wrote:

** Changed in: mixxx/1.10
Assignee: (unassigned) => Daniel Schürmann (daschuer)

** Changed in: mixxx
Assignee: (unassigned) => Daniel Schürmann (daschuer)

** Changed in: mixxx/1.10
Status: Confirmed => In Progress

** Changed in: mixxx
Status: Confirmed => In Progress

--
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.
https://bugs.launchpad.net/bugs/925619

Title:
Resizing library table columns shows blank gaps

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/925619/+subscriptions

[mixxxbot]

Commented by: daschuer
Date: 2012-06-12T18:55:13Z

---

If you just comment out "setCascadingSectionResizes(true)" it will not help, because this property is restored with the header state from library.
Changing it to "setCascadingSectionResizes(false)" afterwards solves the problem. I will change it to for 1.1o and 1.11 because its the default header behaviour in other applications anyway.

[mixxxbot]

Commented by: rryan
Date: 2012-06-12T19:09:48Z

---

sounds good -- thanks guys

On Tue, Jun 12, 2012 at 2:59 PM, Launchpad Bug Tracker <
<email address hidden>> wrote:

** Branch linked: lp:mixxx/1.10

--
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.
https://bugs.launchpad.net/bugs/925619

Title:
Resizing library table columns shows blank gaps

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/925619/+subscriptions

[mixxxbot]

Issue closed with status Fix Released.