Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose recording folder. #6267

Closed
mixxxbot opened this issue Aug 22, 2022 · 7 comments
Closed

Choose recording folder. #6267

mixxxbot opened this issue Aug 22, 2022 · 7 comments
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: mutil
Date: 2012-02-02T19:23:29Z
Status: Fix Released
Importance: Wishlist
Launchpad Issue: lp925663
Attachments: [Patch to implement setting custom mixxx recordings path.](https://bugs.launchpad.net/bugs/925663/+attachment/3096927/+files/Patch to implement setting custom mixxx recordings path.)


Mixxx automatically creates an empty folder (Mixxx/Recordings) inside the music Library.
I think the location should be configurable, and only create it the first time a user wishes to record (preferably after user interaction).

@mixxxbot
Copy link
Collaborator Author

Commented by: hile
Date: 2012-04-21T09:12:38Z
Attachments: [Patch to implement setting custom mixxx recordings path.](https://bugs.launchpad.net/mixxx/+bug/925663/+attachment/3096927/+files/Patch to implement setting custom mixxx recordings path.)


Attached is a patch which adds a library preference to set recordings folder to config key "Recording","Directory". The setting is modified from the 'Recordings' configuration page.

Initially when user has not selected a setting for this folder, we construct the current path (Mixxx/Recordings under music library) and set it as default value in configuration.

The patch checks and changes recording folder whenever user clicks on the 'Recordings' sidebar after changing the folder in preferences.

Patch is against trunk as of today (2012-04-21).

It might be good idea to set a default value in new install configurations to something like $HOME/Music/Mixxx/Recordings instead of writing by default to user's music library: this however is not relevant for this patch.

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2012-04-30T04:59:39Z


Thanks hile! Please sign the contributor agreement here to give us permission to distribute your patch w/ mixxx: https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ#gid=0

@mixxxbot
Copy link
Collaborator Author

Commented by: mutil
Date: 2012-05-19T21:15:28Z


This doesn't seem to work for me on a linux box.
It always writes to the directory from where mixxx was launched.
The directory in UI and in .cfg file is irrelevant.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2012-05-20T10:33:16Z


I can confirm that. I think there were some lines lost during commit.
Fixed in lp:mixxx #⁠3172

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2012-06-08T09:02:44Z


The fix from #⁠4 work only if you choose a custom Recording Directory. Per default Mixxx still writes to the program directory. See lp:1000067

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2012-06-09T21:07:09Z


Since this bug is "Fix committed" the latest issue #⁠5 is tracked in bug #⁠1000067.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 1.11.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant