"load tracks into playing decks" doesn't work

[mixxxbot]

Reported by: florian-mahlknecht-95
Date: 2012-04-21T10:57:29Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp986532
Attachments: changes.patch, changes.patch

---

Even if I activate "load tracks into playing decks" in the settings, I still can't load tracks into playing decks.
In my opinion a check-box would be more intuitive in this case. On the other hand, someone might wants to add an option like "only if the volume is turned down, load the track into a playing deck".

I guess the information about my operating system is useless in this case.

(sorry for my bad English)

[mixxxbot]

Commented by: esbrandt
Date: 2012-04-21T11:11:02Z

---

What version of Mixxx you're running and what is your operating system?

At least with Mixxx 1.10 & latest lp:mixxx on MacOSX 10.6.8 i can not confirm this bug. It just loads as it should into playing decks if the option is activated.

[mixxxbot]

Commented by: florian-mahlknecht-95
Date: 2012-04-21T11:21:10Z

---

I built the 1.11.0 alpha (lp:mixxx) on Ubuntu 11.10 32-bit.

[mixxxbot]

Commented by: florian-mahlknecht-95
Date: 2012-04-21T14:54:24Z
Attachments: changes.patch

---

I've fixed it now!

The problem was, that the entering drag was ignored: wwaveformviewer.cpp:165 and woveriew.cpp:491
I added a private member variable m_pConfig* to these classes to get the required information. Then I changed the initializations in skinparser.cpp. On linux it works. But i don't know if there's a better solution or if the problem occurs only on linux.

To compile it on ubuntu with the GCC, i had to add the following options: -msse -mmmx -msse2
See http://www.linuxquestions.org/questions/ubuntu-63/using-xmmintrin-h-in-ubuntu-707942/

[mixxxbot]

Commented by: daschuer
Date: 2012-04-21T20:53:32Z

---

Hi Florian,

Thank you for the patch.
I can confirm the bug itself and I can confirm that you patch looks good and solves the problem.
I have the same system installed as yours.

I have also noticed that the context menu from the track tables disables the "load to a playing deck" entry as well.
We should consider, if this is a similar bug.

You are right that the default "scons" command will fail. But it should work with:
scons optimize=2

This issue is tracked in Bug #⁠887741.
If you can confirm that the patch from bug Bug #⁠887741 re-enable compiling without your patch and command:
scons optimize=0
You should remove the depend.py part from your patch.

(Please note that scons caches the command line options from previous calls)

[mixxxbot]

Commented by: florian-mahlknecht-95
Date: 2012-04-22T07:26:28Z
Attachments: changes.patch

---

Hi,

I'm sorry, I didn't see the Bug #⁠887741. With the patch "depends2.patch" it compiles fine using "scons optimize=0".
Yes, you're right: in the context menu occurs the same error. I've fixed that as well.

It should work.

[mixxxbot]

Commented by: rryan
Date: 2012-04-22T17:21:23Z

---

Thanks Florian! Could you please sign the Mixxx contributor agreement here:
https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ#gid=0

Also, is it ok to credit you as "Florian Mahlknecht"?

[mixxxbot]

Commented by: florian-mahlknecht-95
Date: 2012-04-22T19:04:45Z

---

My pleasure!
Oh thanks, "Florian Mahlknecht" is great :)

[mixxxbot]

Issue closed with status Fix Released.