Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bzr revision not displayed in builds from http://builds.mixxx.org/builds/trunk/ #6413

Closed
mixxxbot opened this issue Aug 22, 2022 · 9 comments
Labels

Comments

@mixxxbot
Copy link
Collaborator

Reported by: daschuer
Date: 2012-05-08T14:52:54Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp996574
Attachments: buildversion.patch


Its hard to discover which version Mixxx is currently installed because the bzr revision is not displayed in builds from http://builds.mixxx.org/builds/trunk/
(Not in the GUI and also not in Terminal)

Debug [Main]: Mixxx 1.11.0-alpha2 "(built on: May 8 2012 @ 03:58:18; flags: hid
hifieq mad optimize=9 qdebug shoutcast vamp verbose vinylcontrol)" is starting.
..

Wy not always display the bzr revision, also in release builds?

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2012-05-08T15:12:25Z


Hm, how do we keep messing this one up? :) which OS is this?

@mixxxbot mixxxbot added the bug label Aug 22, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2012-05-25T15:12:04Z


Hi RJ
I have tested it only on Ubuntu 64 and 32.
It looks like the build server fails to write buid.h

Deleting deprecated build file: /tmp/buildd/mixxx-1.10.1-alpha/src/build.h
bzr: ERROR: Not a branch: "/tmp/buildd/mixxx-1.10.1-alpha/lin32_build/".
ERROR: Could not determine branch name from output of 'bzr info'. Please file a bug with the output of 'bzr info' attached.
bzr: ERROR: Not a branch: "/tmp/buildd/mixxx-1.10.1-alpha/lin32_build/".
bzr: ERROR: Not a branch: "/tmp/buildd/mixxx-1.10.1-alpha/lin32_build/".
bzr: ERROR: Not a branch: "/tmp/buildd/mixxx-1.10.1-alpha/lin32_build/".

Didn't we moved the build.h to the temporaty build folder?

I think we must also find a solution for tarball builds.
Can you try to generate the build.h at add it to the tarball?

Thank you,

Daniel

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2012-06-07T21:33:44Z


Windows build is not effected.

I am working on a solution for tarball builds!

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2012-06-08T21:41:45Z
Attachments: buildversion.patch


here it is:

The patch creates a lastbzrbuild.h in src folder. It is written at build time when bzr is able to collect the revision info.
It is intended to checkin this file. It is used to generate the bzr info when a tarball build is done.

Maybe its al little annoying tat this file will be changed in every check-in. A better solution is to generate a file like this by a server side hook script, but I think hook scripts are not possible in Launchpad.

Another option would be to create such a file just before packing the official tarball. Bit this does not cover the case when downloading a tarball from launchpad.

Additional I have moved the version things to a separate file to save some compile time. Also it was a little frustrating how long it takes for my netbook to compile such a simple class :-(

The original bug seems to be an issue on our buildverver. It looks like the .bzr folder was lost before calling scons.
@RJ: can you have a look, Thank you!

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2012-06-09T15:56:56Z


Hi RJ,

Ok, my new lastbzrbuild.h is a candidate for continuous conflicts. So this solution is more annoying then it helps for now.
We should consider how we can put this file in our official source package and triag the tracability in case of Launchpad tarball downloads.

I think a scons option, only set by our build server could be a solution.
What do you think?

Kind regards,

Daniel

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2012-06-20T17:28:50Z


I agree -- I think the fix should be done on the build server just limited
to the Ubuntu packaging portion of the sconscript. Maybe we can include
build.h when we build the source tarball.

On Sat, Jun 9, 2012 at 11:56 AM, Daniel Schürmann <

wrote:

Hi RJ,

Ok, my new lastbzrbuild.h is a candidate for continuous conflicts. So this
solution is more annoying then it helps for now.
We should consider how we can put this file in our official source package
and triag the tracability in case of Launchpad tarball downloads.

I think a scons option, only set by our build server could be a solution.
What do you think?

Kind regards,

Daniel

--
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.
https://bugs.launchpad.net/bugs/996574

Title:
bzr revision not displayed in builds from
http://builds.mixxx.org/builds/trunk/

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/996574/+subscriptions

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2012-06-20T19:25:32Z


Hi RJ,
I have no access to the build server scripts.
Will you take care of it or what else can I do?

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2012-10-15T05:55:46Z


Should be fixed since lp:mixxx/1.11 #⁠3370.
Tested with 1.11.0-beta2-pre (build r3419) on Ubuntu 64 Precise.
Thank you RJ!

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant