Keyboard Mapping for Auto DJ Functions (Vs. 1.11)

[mixxxbot]

Reported by: ub7-marcus
Date: 2012-05-30T18:22:41Z
Status: Fix Released
Importance: Wishlist
Launchpad Issue: lp1006550
Tags: autodj, easy, weekend
Attachments: bug1006550.patch, bug1006550.patch

---

rryan asked me to add this to the bug reports. Not a bug as such but something that would be nice if included.

Here's what i wrote on the forum:

Is it possible to map the Auto DJ functions such as shuffle, skip track, fade now and most importantly the enable/disable button. I'd like to set these up on my keyboard (i've made some customizations already in conjunction with my midi controller) and just wondered, assuming it's possible, what the parameter titles were as they're not mentioned in the Wiki?

[mixxxbot]

Commented by: ub7-marcus
Date: 2012-05-30T19:29:57Z

---

Would also like to have included an "add to auto dj" parameter as a keyboard shortcut!

[mixxxbot]

Commented by: ub7-marcus
Date: 2012-05-31T16:18:00Z

---

thx for doing that so quickly!
where would i find a list of those tags, i'd like to test it out with the beta?

[mixxxbot]

Commented by: daschuer
Date: 2012-05-31T17:25:20Z

---

Sorry Harry, those tags helps us finding this bug, not more :-(

[mixxxbot]

Commented by: ub7-marcus
Date: 2012-05-31T17:32:51Z

---

ooops, totally misunderstood ...no worries!

[mixxxbot]

Commented by: rryan
Date: 2012-06-05T21:08:56Z

---

We can do this for 1.11 as a 'maybe if someone has time' sort of thing. Also this should be pretty easy if any new contributors want to pick it up.

[mixxxbot]

Commented by: smstewart91
Date: 2012-06-14T05:26:43Z
Attachments: bug1006550.patch

---

Here is a patch. I added fade_now, skip_next, shuffle_playlist, and toggle_autodj to the [AutoDJ] group
Feedback and extra testing appreciated :)

[mixxxbot]

Commented by: smstewart91
Date: 2012-06-14T05:27:57Z

---

Just read back over the bug and realized that I missed "add to autodj". I will add that and post a patch back up

[mixxxbot]

Commented by: ub7-marcus
Date: 2012-06-14T08:05:55Z

---

I will be happy to try this out once you've got the new patch ready

[mixxxbot]

Commented by: daschuer
Date: 2012-06-14T11:24:24Z

---

Hi Scott,

thank you for your patch!

Here are my comments:

• Please make sure your code full fills http://www.mixxx.org/wiki/doku.php/coding_guidelines. There are many places in Mixxx with different style, but the target is to have a unified code base.
• Please set your editors, including meld for using 4 spaces instead of a single tab.
• Please delete your new pushbuttons in the Class destructor
• The QT ui GUI button are bypassing the Control objects. This will work for a quick fix like this, but it breaks a little bit the concept of control objects. I am not sure if this matters for 1.11.

[mixxxbot]

Commented by: rryan
Date: 2012-07-10T14:37:25Z

---

Hi Scott -- any update on this patch? It'd be nice to get it into Mixxx 1.11.0

[mixxxbot]

Commented by: smstewart91
Date: 2012-07-10T15:34:37Z

---

Hi RJ,
I found a good solution while working on other stuff, so I'll be updating
the patch by the end of the week.

Scott
On Jul 10, 2012 7:46 AM, "RJ Ryan" <email address hidden> wrote:

Hi Scott -- any update on this patch? It'd be nice to get it into Mixxx
1.11.0

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1006550

Title:
Keyboard Mapping for Auto DJ Functions (Vs. 1.11)

Status in Mixxx:
In Progress

Bug description:
rryan asked me to add this to the bug reports. Not a bug as such but
something that would be nice if included.

Here's what i wrote on the forum:

Is it possible to map the Auto DJ functions such as shuffle, skip
track, fade now and most importantly the enable/disable button. I'd
like to set these up on my keyboard (i've made some customizations
already in conjunction with my midi controller) and just wondered,
assuming it's possible, what the parameter titles were as they're not
mentioned in the Wiki?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/1006550/+subscriptions

[mixxxbot]

Commented by: smstewart91
Date: 2012-07-20T16:44:37Z
Attachments: bug1006550.patch

---

Here is an updated patch that updates the ControlObjects. I couldn't find a way to turn "add selected track" into a mappable function, so if anyone has ideas for that one, please share

[mixxxbot]

Commented by: rryan
Date: 2012-07-20T17:48:37Z

---

Thanks Scott -- I reworked the toggle one a little bit so that the ControlPushButton is a push and not a toggle button (making it a toggle stores the state in the CO while the Qt push button also stores the state by virtue of its 'checked' property). Committed to lp:mixxx/1.11 r3322.

[mixxxbot]

Issue closed with status Fix Released.