Add slip_enabled and beatlooproll_x_activate to Midi wizard and tooltips

[mixxxbot]

Reported by: esbrandt
Date: 2012-09-13T20:13:06Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1050597
Tags: midi, usability
Attachments: slip_and_roll.patch, slip_and_roll2.patch

---

This is a follow up to lp:703585 - Slip mode

Patch

• adds support for both controls , slip_enabled and beatlooproll_x_activate, to midi   wizard and tooltips.
• adds some missing tr`s for i18n to midi wizard.
• adds some beatloop_X values currently missing to midi wizard.
    Note: Is it still correct to use the deprecated beatloop_X here instead of beatloop_X_toggle?
• changes the smallest loop size to 0.03125 (1/32th) which sound pretty cool e.g. when   working with loop rolls and and the pitch fader with a wide pitch rate.

I have tested the patch with OSX and a Midi controller.

Please check grammar and spelling in the patch`s tooltips part.

[mixxxbot]

Commented by: esbrandt
Date: 2012-09-13T20:13:06Z
Attachments: slip_and_roll.patch

[mixxxbot]

Commented by: rryan
Date: 2012-09-13T20:29:54Z

---

Looks good -- thanks!

[mixxxbot]

Commented by: rryan
Date: 2012-09-13T20:32:22Z

---

Single grammar change:

"Temporary setup a rolling loop"
Temporary should be Temporarily

[mixxxbot]

Commented by: esbrandt
Date: 2012-09-17T10:33:07Z

---

Thanks RJ for looking at.
Regarding my question from #⁠1, we are still fine when using beatloop_X?

[mixxxbot]

Commented by: broma0-deactivatedaccount
Date: 2012-09-17T13:36:43Z

---

Patch works perfectly for me on revision 3397.

[mixxxbot]

Commented by: rryan
Date: 2012-09-26T02:03:09Z

---

Hi jus -- I think we should switch to using beatloop_X_toggle. Good catch.

[mixxxbot]

Commented by: esbrandt
Date: 2012-09-26T07:16:31Z
Attachments: slip_and_roll2.patch

---

Updated patch

• Grammar fix
• Use beatloop_X_toggle in dlgcontrollerlearning.cpp
• Use beatloop_X_toggle across all *kbd.cfg, currently we used it only in en_US.kbd.cfg

Im unsure if i need to change from beatloop_X to beatloop_X_toggle in controlvaluedelegate.cpp too, since various controller scripts use still beatloop_X

[mixxxbot]

Commented by: rryan
Date: 2012-09-26T14:34:33Z

---

ControlValueDelegate is unused code at the moment since it describes what
controls to show in the drop-down when editing a MIDI mapping. I think
beatloop_X_toggle would be the right thing (or maybe both) to put there as
well.

On Wed, Sep 26, 2012 at 3:16 AM, jus wrote:

Updated patch

• Grammar fix
• Use beatloop_X_toggle in dlgcontrollerlearning.cpp
• Use beatloop_X_toggle across all *kbd.cfg, currently we used it only in
  en_US.kbd.cfg

Im unsure if i need to change from beatloop_X to beatloop_X_toggle in
controlvaluedelegate.cpp too, since various controller scripts use still
beatloop_X

** Patch added: "slip_and_roll2.patch"

https://bugs.launchpad.net/mixxx/+bug/1050597/+attachment/3344244/+files/slip_and_roll2.patch

--
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.
https://bugs.launchpad.net/bugs/1050597

Title:
Add slip_enabled and beatlooproll_x_activate to Midi wizard and
tooltips

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/1050597/+subscriptions

[mixxxbot]

Commented by: rryan
Date: 2012-10-04T05:02:29Z

---

Committed the patch -- thanks jus.

[mixxxbot]

Issue closed with status Fix Released.