Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing transparency in ghost image of outline skin #6673

Closed
mixxxbot opened this issue Aug 22, 2022 · 7 comments
Closed

missing transparency in ghost image of outline skin #6673

mixxxbot opened this issue Aug 22, 2022 · 7 comments
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: daschuer
Date: 2012-10-25T21:21:31Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1071500
Tags: skin


The he vinyl_spinny1_foreground_ghost.png hides the normal indicator.

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2012-10-25T21:40:31Z


The Outline skin use the color schemes which does not support image transparency. Unless this is fixed, i guess we have to live with that.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2012-12-13T22:38:29Z


I have enabled transparent Images in color scheme skins and made the outline spinny overlay images transparent.
commited to lp:mixxx/1.11 #⁠3623

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2012-12-16T06:53:19Z


Nice one, thanks Daniel.
This bugged me a long time and maybe it will breathe into it new life into color scheme skins. One thing we need to allow are background images on WidgetGroups which will support color schemes. Will file a separate wishlish item for that.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2012-12-16T12:38:24Z


I am not sure if I get your last point. My solution simple does not remove transparency from the source file of all images.
Please name a specific image where something is not as desired, so I can have a look.

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2012-12-23T11:25:39Z


Well, If you have a skin which uses color schemes and you would like to add sampler or preview decks support, how do you currently style the WidgetGroups background image?
You can 
a) add a background image via <style> CSS declaration for WidgetGroups, but the color scheme support does not work on these. This is what we currently use for fixed size SampleDecks in all skins except Outline. The PreviewDeck has no background image, we use only boarders here because of resizing.
b) add a dummy button that serves no other function than to provide the background image for the sampler which can than be styled using the Mixxx color scheme support. This is what we currently use in Outline. The problem with that approach is, that you cant resize the button and resizable CSS styled boarders do not support color scheme. Thats the reason Outline skins do not have a full PreviewDeck yet.

tldr: We miss a resizable <Background> image (alternatively border images) for WidgetGroups which support color schemes.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2012-12-30T23:58:35Z


Issue from the latest comments is solved with the patch from bug #⁠1094785

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 1.11.0 milestone Aug 24, 2022
@ronso0 ronso0 added skins and removed skin labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants