EngineBuffer code clean up

[mixxxbot]

Reported by: daschuer
Date: 2012-11-30T21:55:51Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1085224
Attachments: enginebuffer_cleanup.patch

---

Attached you find a patch which removes some unnecessary code from EngineBuffer and prefixes all member variables with m_

[mixxxbot]

Commented by: daschuer
Date: 2012-11-30T21:55:51Z
Attachments: enginebuffer_cleanup.patch

[mixxxbot]

Commented by: rryan
Date: 2012-11-30T22:31:34Z

---

Thanks.. some long-needed cleanups. The patch looks good:

• It adds ControlObjectThreadMain header and fwd declaration back in -- can remove those.
• Some controls are no longer deleted in the destructor (visual bpm, visual playposition, slip enabled, slip position, etc.).

This is going to cause pretty much every line of the engine-control-refactor branch to conflict though :(.

[mixxxbot]

Commented by: rryan
Date: 2012-11-30T22:31:48Z

---

(every line in EngineBuffer)

[mixxxbot]

Commented by: daschuer
Date: 2012-11-30T23:42:02Z

---

Commited to lp:mixxx/1.11 revision 3539

[mixxxbot]

Issue closed with status Fix Released.